-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs for building a custom docker image #145
Comments
I am using the docker file and i am noticing that this might not be the best way for a dockerfile that is meant to only build locally. Would it make sense for example to create a new one say Dockerfile.build ? |
What do you mean only build locally? |
I don't believe we can mount stuff in when building a container. It has to be copied. Furthermore, you don't see any of these artifacts in the resulting image because we're using a multi staged build. |
I think we are mixing 2 separate use cases
If someone is in 1) then it makes sense to not copy the source code in the image but mount it later when the container is started . The dockerfile would only make sure the used binaries are always the same across the possible combinations of environments and should make supporting it easier. |
Do you want a I'm not sure I see the value here. @kylecarbs do we have support for incremental compilation or will each build still take 20m? |
Well maybe you can document what you do now :-) i imagine it does not take 20m to build it incrementally. This was my original question but then it drifted to using a docker file. |
Going to close as it has been a while and I'm not sure if this is relevant anymore. |
No description provided.
The text was updated successfully, but these errors were encountered: