Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU][WK1] Code Review: Music Playlist Explorer #8

Open
alegleason opened this issue Jun 12, 2024 · 0 comments
Open

[MU][WK1] Code Review: Music Playlist Explorer #8

alegleason opened this issue Jun 12, 2024 · 0 comments

Comments

@alegleason
Copy link

Overall solid work. As discussed on our 1:1s you prefer a centralized place for feedback, so let's use an issue for this assignment and take it from here.

  1. In the README file I recommend removing the Deployed Application link if it's not applicable. Let's probably leave a comment there on the deployment status.
  2. Let's try to have the GIF/Vid added to the README next time, here are some tutorials you might find useful - the demo is great though -:
  1. Try to make the commit titles more action oriented - What did you do? Infinitive tense works great! You don't need to add next steps. These can be commented. An example, instead of "modal is up", we can do "[HTML][JS] Implement modal design and functionality".
  2. Also, adding visual elements to commits, is highly recommended but optional for now - they should describe what your change is doing.
  3. Check out for committing commented out code.
  4. I recommend reading https://kyleschaeffer.com/css-font-size-em-vs-px-vs-pt-vs-percent
  5. General feedback on comments (eg., a50bd01)
  6. Some styling comments throughout the commits!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant