Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple mode: Cannot use empty string matching for last group of regex #6618

Closed
Billiam opened this issue Mar 9, 2021 · 1 comment
Closed

Comments

@Billiam
Copy link
Contributor

Billiam commented Mar 9, 2021

I think this is a bug, but might just be a documentation issue.

It seems like simple mode's regex can match an empty string for any group except the last group of the regex.
Otherwise, Uncaught TypeError: Cannot read property 'text' of undefined will be thrown when entering on the next line (see video)

I believe matching an empty string is intended behavior, based on the solution given in #5374

Example: https://codepen.io/billiam/pen/poNxZMw

simplemode.mp4
@marijnh
Copy link
Member

marijnh commented Mar 9, 2021

That was a bug. Attached patch should fix it.

@marijnh marijnh closed this as completed in 769daa5 Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants