[match-highlighter] Added wordsOnly option #2791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieleds
changed the title
| } | ||
| if (this.style == null) this.style = DEFAULT_TOKEN_STYLE; | ||
| if (this.minChars == null) this.minChars = DEFAULT_MIN_CHARS; | ||
| if (this.delay == null) this.delay = DEFAULT_DELAY; | ||
| if (this.wordsOnly == null) this.delay = DEFAULT_WORDS_ONLY; |
There was a problem hiding this comment.
You have this.delay where it should be this.wordsOnly.
|
Sorry, is this ready to be merged? |
|
Yes, it is. Merged as f09b6c5 Note that I do not get an email notification when you push to a pull request branch, and thus am unlikely to notice. It is a good idea to add a comment when you want me to look at the code again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to highlight the selection only if it's a word.
The "delay" option was missing from the documentation, I added it.