Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IncomingRequest getUserAgent problem only object #948

Closed
byazrail opened this issue Feb 22, 2018 · 2 comments
Closed

IncomingRequest getUserAgent problem only object #948

byazrail opened this issue Feb 22, 2018 · 2 comments

Comments

@byazrail
Copy link
Contributor

byazrail commented Feb 22, 2018

Hi guys,

public function getUserAgent($onlyObject = false) { return ($onlyObject === true) ? $this->userAgent : $this->userAgent->getAgentString(); }

@lonnieezell
Copy link
Member

I'm assuming this is a proposal? An explanation to go along with the comment is always good so I don't have to go attempting to decipher your intent. :)

Actually - the intent was to add a _toString so that you could echo it out, and it looks like I forgot that. That would be the solution I'd accept.

@byazrail
Copy link
Contributor Author

Yes __toString correct solution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants