New Toolbar Collector for Events

[lonnieezell]

Should show event name and timing, both in it's own tab and in the timeline.

Development Checklist:

• Component(s)
• ... with PHPdocs
• Unit testing
• ... with >80% coverage
• User guide updated
• Classmap integration?
• Securely signed commits
• Conforms to style guide

[filisko]

Hi @lonnieezell,
What about 4 columns like the ones I have in the image? (Time, Event, Priority and Times Triggered).

I just started working on this (so don't pay too much attention to what you see).

[lonnieezell]

@filisko I think that's a good start. Ideally, it would be awesome to be able to expand each row and see the data that was passed to each event. That, I think, would be quite helpful. Unfortunately, there's no mechanism yet for the expanding rows. It's on my wishlist for the toolbar, but haven't made it there yet :)

[ranjithsiji]

@filisko this is a very good idea to have in the debug bar. 👍

[filisko]

Didn't have too much time last weeks, sorry. Now getting back to this.

@lonnieezell, should I try to do a PR once I've got the 'Time' column working and the tests added?

@ranjithsiji yes it is!

[lonnieezell]

@filisko yes, a PR is exactly correct.

[filisko]

Hi @lonnieezell,

• Does 'DBQuery' event need to be shown in the Events collector?
• Should we show the events that don't have any registered action (Events::on()) but that were triggered?
• Should we rename 'post_controller_constructor' event to something like ... 'postControllerConstructor' ?

[lonnieezell]

@filisko Good questions.

1. No, don't need to include DBQuery events. Primarily interested in user-generated events.
2. Yes, I think we should show all events. That will help be a trigger to developers looking to see if all of their events are firing.
3. Probably should. Which means all system events should be renamed (with docs updated). I think there are a grand total of 4).

Thanks!

[filisko]

@lonnieezell, is it good idea to trigger events inside the Events class?

[lonnieezell]

Initial thought is, "No", but would need more details.

[filisko]

so directly call to the Events Collector from the Events class on dev environment would be the best solution?

[lonnieezell]

Oh, I see what you're saying. Yes, I think so. Otherwise I can see it getting into a loop and never getting out.

[filisko]

Yes !!! You totally got it! I thought that it would take you more time to realize that 😄 because had no idea of how much you knew about that code.
Thank you!

[lonnieezell]

:) Was I doing that in the code or something?