Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute bootstrapEnvironment() & detectEnvironment() before Services::exceptions() #3138

Closed
arma7x opened this issue Jun 20, 2020 · 2 comments
Labels
refactor Pull requests that refactor code

Comments

@arma7x
Copy link
Contributor

arma7x commented Jun 20, 2020

I did override current Services::exceptions() and my new Services::exceptions() need to access specific value of CONSTANT loaded from custom boot files based upon the current environment.
Posibble to update Codeigniter.php by moving Line 190 below Line 194

@arma7x arma7x added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 20, 2020
@arma7x arma7x changed the title Refactor:Execute bootstrapEnvironment() & detectEnvironment() before Services::exceptions() Execute bootstrapEnvironment() & detectEnvironment() before Services::exceptions() Jun 20, 2020
@arma7x
Copy link
Contributor Author

arma7x commented Jun 20, 2020

Sorry for missmatch label, this is refactor request

@michalsn michalsn added refactor Pull requests that refactor code and removed bug Verified issues on the current code behavior or pull requests that will fix them labels Jun 21, 2020
@michalsn
Copy link
Member

I think it shouldn't cause problems. And your reasoning to have access to the environment variables make sense to me.

You should try to make a PR (if you want to this change happen sooner rather than later 😉).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

No branches or pull requests

2 participants