-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: About the SameSite COOKIE RFC changes for PHP > 7.3 #2374
Comments
@lonnieezell Is this something overlooked? It feels like a feature request more than a bug. |
Looks like OP was using a bit of a hack to get it to work. I think it's a worthy addition - but definitely a new feature. Tag it for the first release after 4.0 I think. |
The problem for this to fix it well it is a bit of a change if you want to add the feature i just documented myself, and with the setcookie function the settings of the session should be passed as array not as simple variables.... So i understand for this you will have to change a lot of stuff. What i think is to make it work now at the present and not focuse on this task in the future... This is a major concern this will help other problems to be solved... |
There exists a workaround for PHP < 7.3. Following code is from
|
after 4 months i am happy this was added in, seriously :) |
Hello in the old Codeigniter 3
i had an option to use this directly on the config of cookiePath...
$cookiePath = '/; SameSite=strict'
setcookie('samesite-test', '1', 0, '/; samesite=strict');
Now with the new C4 this doesnt work anymore
Please introduce this SameSite Cookie config setting into the
Config/App.php File
$cookieSameSite = 'strict'; // or lax; i think they are 3 options, none, strict and lax... that have to be implemented..
Please guys send a message if you are thinking of implementing this.
Because for me this is very important !
// by default or something....
The text was updated successfully, but these errors were encountered: