Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url_helper functions don't correctly apply $baseURL #155

Closed
lonnieezell opened this issue Jul 11, 2016 · 0 comments
Closed

url_helper functions don't correctly apply $baseURL #155

lonnieezell opened this issue Jul 11, 2016 · 0 comments
Assignees
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Milestone

Comments

@lonnieezell
Copy link
Member

The path portion of $baseURL is not applied correctly base_url() and system_url() functions.

Example:
$baseURL = 'http://example.com/blog/';

helper('url');
echo base_url();

// Outputs http://example.com
// Should be http://example.com/blog

Looks like the methods should use URI::resolveRelativeURI() to join the paths. And ensure the path is set correctly by IncomingRequest.

Discovered via #148

@lonnieezell lonnieezell added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 11, 2016
@lonnieezell lonnieezell added this to the Pre-Alpha 2 milestone Jul 11, 2016
@lonnieezell lonnieezell self-assigned this Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

No branches or pull requests

1 participant