Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of proper instruction in documentation for changing Application and System folder name #1366

Closed
mbparvezme opened this issue Oct 27, 2018 · 2 comments
Labels
documentation Pull requests for documentation only in progress
Milestone

Comments

@mbparvezme
Copy link


name: Bug report
about: Application and System folder name change


Describe the bug
According to the doc, to change the Application and System folder name we should change the $systemDirectory and $applicationDirectory in application/Config/Path.php.

Actually this is not enough. Along with the we have to change this two variables in index.php file, $pathsPath = FCPATH . '../application/Config/Paths.php'; and $app = require FCPATH . '../system/bootstrap.php'; as they are containing the folders name.

CodeIgniter 4 version
Version 4.0.0-alpha.2

Context

  • OS: Windows 10
  • Web server Apache/2.4.35 (Win32) OpenSSL/1.1.0i
  • PHP 7.2.11
@jim-parry
Copy link
Contributor

This will be addressed with the repo reorg.

@jim-parry jim-parry added in progress documentation Pull requests for documentation only labels Nov 1, 2018
@jim-parry jim-parry added this to the 4.0.0 milestone Nov 13, 2018
@TatwiraT
Copy link

TatwiraT commented Nov 17, 2018

also a pretty change would be better on :
file : system\Config\Services::render() : L487
move up the logic check of
if (is_null($viewPath)) { $paths = config('Paths'); $viewPath = $paths->viewDirectory; }
as the first operation to check in order to avoid getting error if the application/Views is moved out or renamed.
also , the changing of viewsDirectory must verify the absolute location of the folder, cause now if the Views is moved to the root path, it won"t work untill adding the parent location two dots "../views"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only in progress
Projects
None yet
Development

No branches or pull requests

3 participants