Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLLite3 Forge needs better column handling #1255

Closed
jim-parry opened this issue Sep 27, 2018 · 2 comments
Closed

SQLLite3 Forge needs better column handling #1255

jim-parry opened this issue Sep 27, 2018 · 2 comments
Labels
database Issues or pull requests that affect the database layer missing feature Reported issue which is not a bug but needs to be implemented

Comments

@jim-parry
Copy link
Contributor

Database/SQLite3/Forge::_alterTable(...) has a todo note...
implement drop_column(), modify_column()
@jim-parry jim-parry added the missing feature Reported issue which is not a bug but needs to be implemented label Sep 27, 2018
@jim-parry jim-parry added this to the 4.0.1? milestone Sep 27, 2018
@lonnieezell
Copy link
Member

So - this looks to be a giant pain in the ass. SQlite3 does not support drop column or modify column. You have to go through a bunch of steps including creating a new table with the dropped column and then renaming the column.

While it would still be good to implement, definitely not happening for 4.0 initial release.

http://www.sqlitetutorial.net/sqlite-alter-table/

@jim-parry jim-parry removed this from the 4.0.1? milestone Nov 14, 2018
@jim-parry jim-parry changed the title TODO SQLLite3 Forge needs better column handling SQLLite3 Forge needs better column handling Nov 14, 2018
@jim-parry jim-parry added the database Issues or pull requests that affect the database layer label Dec 10, 2018
@lonnieezell
Copy link
Member

Fixed in #1737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
database Issues or pull requests that affect the database layer missing feature Reported issue which is not a bug but needs to be implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lonnieezell @jim-parry