Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO BaseConnection needs better error handling #1254

Closed
jim-parry opened this issue Sep 27, 2018 · 2 comments
Closed

TODO BaseConnection needs better error handling #1254

jim-parry opened this issue Sep 27, 2018 · 2 comments
Assignees
@lonnieezell
Labels
database Issues or pull requests that affect the database layer missing feature Reported issue which is not a bug but needs to be implemented
Milestone
4.0.*

Comments

@jim-parry
Copy link
Contributor

Database/BaseCOnnection::query(...) has a todo note...
deal with errors (they are currently ignored)
@jim-parry jim-parry added the refactor Pull requests that refactor code label Sep 27, 2018
@jim-parry jim-parry added this to the 4.0.1? milestone Sep 27, 2018
@jim-parry jim-parry added missing feature Reported issue which is not a bug but needs to be implemented and removed refactor Pull requests that refactor code labels Sep 27, 2018
@lonnieezell lonnieezell self-assigned this Nov 16, 2018
@jim-parry jim-parry mentioned this issue Nov 16, 2018
Merged
@jim-parry
Copy link
Contributor Author

@lonnieezell Cleaning up todo tags :-/

@lonnieezell
Copy link
Member

I saw that! Though in this case you were a bit pre-mature. You just returned instead of handling the error. I need to look back at the original driver, but I believe the intent was to capture any errors that happened during a transaction and display them to the user (depending on CI_DEBUG setting?) after the transaction has been closed.

@jim-parry jim-parry added the database Issues or pull requests that affect the database layer label Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lonnieezell lonnieezell

Labels
database Issues or pull requests that affect the database layer missing feature Reported issue which is not a bug but needs to be implemented
Projects
None yet
Milestone
4.0.*
Development

No branches or pull requests
2 participants
@lonnieezell @jim-parry