From 9773ed11ad134a79492dc4bdf59384d352df81c5 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 5 Nov 2024 15:04:03 +0000 Subject: [PATCH 1/3] chore(deps-dev): update rector/rector requirement from 1.2.8 to 1.2.9 Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version. - [Release notes](https://github.com/rectorphp/rector/releases) - [Commits](https://github.com/rectorphp/rector/compare/1.2.8...1.2.9) --- updated-dependencies: - dependency-name: rector/rector dependency-type: direct:development ... Signed-off-by: dependabot[bot] --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index e6533a6daea1..34178265c11c 100644 --- a/composer.json +++ b/composer.json @@ -28,7 +28,7 @@ "phpunit/phpcov": "^9.0.2 || ^10.0", "phpunit/phpunit": "^10.5.16 || ^11.2", "predis/predis": "^1.1 || ^2.0", - "rector/rector": "1.2.8" + "rector/rector": "1.2.9" }, "replace": { "codeigniter4/framework": "self.version" From e63774d93239d9726d132ff7d7068a31047a363d Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Tue, 5 Nov 2024 22:10:16 +0700 Subject: [PATCH 2/3] skip NarrowUnusedSetUpDefinedPropertyRector as buggy with default value Signed-off-by: Abdul Malik Ikhsan --- rector.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/rector.php b/rector.php index be9e45f1e169..a251d6e80595 100644 --- a/rector.php +++ b/rector.php @@ -59,6 +59,7 @@ use Utils\Rector\PassStrictParameterToFunctionParameterRector; use Utils\Rector\RemoveErrorSuppressInTryCatchStmtsRector; use Utils\Rector\UnderscoreToCamelCaseVariableNameRector; +use Rector\PHPUnit\CodeQuality\Rector\Class_\NarrowUnusedSetUpDefinedPropertyRector; return RectorConfig::configure() ->withPhpSets(php81: true) @@ -176,6 +177,9 @@ // Unnecessary (string) is inserted NullToStrictStringFuncCallArgRector::class, + + // buggy with default value + NarrowUnusedSetUpDefinedPropertyRector::class, ]) // auto import fully qualified class names ->withImportNames(removeUnusedImports: true) From a933bf79bd2c2f0460fe92b2d5a9216d9d51e32d Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Tue, 5 Nov 2024 22:11:19 +0700 Subject: [PATCH 3/3] run cs fix on rector.php Signed-off-by: Abdul Malik Ikhsan --- rector.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rector.php b/rector.php index a251d6e80595..6a4a37835fc4 100644 --- a/rector.php +++ b/rector.php @@ -43,6 +43,7 @@ use Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector; use Rector\Php80\Rector\FunctionLike\MixedTypeRector; use Rector\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector; +use Rector\PHPUnit\CodeQuality\Rector\Class_\NarrowUnusedSetUpDefinedPropertyRector; use Rector\PHPUnit\CodeQuality\Rector\Class_\YieldDataProviderRector; use Rector\PHPUnit\Set\PHPUnitSetList; use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector; @@ -59,7 +60,6 @@ use Utils\Rector\PassStrictParameterToFunctionParameterRector; use Utils\Rector\RemoveErrorSuppressInTryCatchStmtsRector; use Utils\Rector\UnderscoreToCamelCaseVariableNameRector; -use Rector\PHPUnit\CodeQuality\Rector\Class_\NarrowUnusedSetUpDefinedPropertyRector; return RectorConfig::configure() ->withPhpSets(php81: true)