From 11146689d579e6add250f020f1dad75ff25aa559 Mon Sep 17 00:00:00 2001
From: kenjis <kenji.uui@gmail.com>
Date: Wed, 22 Jun 2022 21:22:05 +0900
Subject: [PATCH] test: fix tests for permit_empty

---
 tests/system/Validation/RulesTest.php | 47 +++++++++++++++++++--------
 1 file changed, 34 insertions(+), 13 deletions(-)

diff --git a/tests/system/Validation/RulesTest.php b/tests/system/Validation/RulesTest.php
index d4c15816294f..9430cc83fda2 100644
--- a/tests/system/Validation/RulesTest.php
+++ b/tests/system/Validation/RulesTest.php
@@ -128,39 +128,60 @@ public function testPermitEmpty(array $rules, array $data, bool $expected): void
     public function providePermitEmptyCases(): Generator
     {
         yield from [
+            // If the rule is only `permit_empty`, any value will pass.
             [
-                ['foo' => 'permit_empty'],
+                ['foo' => 'permit_empty|valid_email'],
                 ['foo' => ''],
                 true,
             ],
             [
-                ['foo' => 'permit_empty'],
+                ['foo' => 'permit_empty|valid_email'],
                 ['foo' => '0'],
-                true,
+                false,
             ],
             [
-                ['foo' => 'permit_empty'],
+                ['foo' => 'permit_empty|valid_email'],
+                ['foo' => '-0'],
+                false,
+            ],
+            [
+                ['foo' => 'permit_empty|valid_emails'],
                 ['foo' => 0],
-                true,
+                false,
+            ],
+            [
+                ['foo' => 'permit_empty|valid_email'],
+                ['foo' => -0],
+                false,
             ],
             [
-                ['foo' => 'permit_empty'],
+                ['foo' => 'permit_empty|valid_email'],
                 ['foo' => 0.0],
-                true,
+                false,
             ],
             [
-                ['foo' => 'permit_empty'],
-                ['foo' => null],
-                true,
+                ['foo' => 'permit_empty|valid_emails'],
+                ['foo' => '0.0'],
+                false,
             ],
             [
-                ['foo' => 'permit_empty'],
-                ['foo' => false],
+                ['foo' => 'permit_empty|valid_email'],
+                ['foo' => -0.0],
+                false,
+            ],
+            [
+                ['foo' => 'permit_empty|valid_email'],
+                ['foo' => '-0.0'],
+                false,
+            ],
+            [
+                ['foo' => 'permit_empty|valid_email'],
+                ['foo' => null],
                 true,
             ],
             [
                 ['foo' => 'permit_empty|valid_email'],
-                ['foo' => ''],
+                ['foo' => false],
                 true,
             ],
             [