From aed49ae808b7e9e618f68dc3aebc3b161ad7671d Mon Sep 17 00:00:00 2001
From: Olivier Lamy <olamy@apache.org>
Date: Wed, 27 Jul 2022 10:43:01 +1000
Subject: [PATCH] add it for issue #183 but using javac compiler, use
 properties for versions in its

Signed-off-by: Olivier Lamy <olamy@apache.org>
---
 .../src/main/it/MCOMPILER-346-mre/pom.xml     |  5 ++-
 .../src/main/it/aspectj-compiler/pom.xml      |  7 +--
 .../it/eclipse-compiler-mapstruct/pom.xml     |  8 ++--
 .../src/main/it/error-prone-compiler/pom.xml  |  3 +-
 .../it/missing-warnings/invoker.properties    | 20 +++++++++
 .../src/main/it/missing-warnings/pom.xml      | 45 +++++++++++++++++++
 .../src/main/java/com/company/SomeClass.java  |  5 +++
 .../src/main/java/module-info.java            |  3 ++
 .../main/it/missing-warnings/verify.groovy    | 24 ++++++++++
 .../it/simple-eclipse-compiler-fail/pom.xml   |  5 ++-
 .../main/it/simple-eclipse-compiler/pom.xml   |  5 ++-
 .../src/main/it/simple-javac-fork/pom.xml     |  7 +--
 .../src/main/it/simple-javac/pom.xml          |  9 ++--
 pom.xml                                       |  2 +
 14 files changed, 127 insertions(+), 21 deletions(-)
 create mode 100644 plexus-compiler-its/src/main/it/missing-warnings/invoker.properties
 create mode 100644 plexus-compiler-its/src/main/it/missing-warnings/pom.xml
 create mode 100644 plexus-compiler-its/src/main/it/missing-warnings/src/main/java/com/company/SomeClass.java
 create mode 100644 plexus-compiler-its/src/main/it/missing-warnings/src/main/java/module-info.java
 create mode 100644 plexus-compiler-its/src/main/it/missing-warnings/verify.groovy

diff --git a/plexus-compiler-its/src/main/it/MCOMPILER-346-mre/pom.xml b/plexus-compiler-its/src/main/it/MCOMPILER-346-mre/pom.xml
index 5fcea033..c8a739f3 100644
--- a/plexus-compiler-its/src/main/it/MCOMPILER-346-mre/pom.xml
+++ b/plexus-compiler-its/src/main/it/MCOMPILER-346-mre/pom.xml
@@ -29,6 +29,7 @@
   <url>https://github.com/basil/MCOMPILER-346-mre</url>
   <properties>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+    <plexus.compiler.version>@pom.version@</plexus.compiler.version>
   </properties>
   <dependencies>
     <dependency>
@@ -61,12 +62,12 @@
           <dependency>
             <groupId>org.codehaus.plexus</groupId>
             <artifactId>plexus-compiler-api</artifactId>
-            <version>@pom.version@</version>
+            <version>${plexus.compiler.version}</version>
           </dependency>
           <dependency>
             <groupId>org.codehaus.plexus</groupId>
             <artifactId>plexus-compiler-javac</artifactId>
-            <version>@pom.version@</version>
+            <version>${plexus.compiler.version}</version>
           </dependency>
         </dependencies>
       </plugin>
diff --git a/plexus-compiler-its/src/main/it/aspectj-compiler/pom.xml b/plexus-compiler-its/src/main/it/aspectj-compiler/pom.xml
index 8c7ab602..4638fbcb 100644
--- a/plexus-compiler-its/src/main/it/aspectj-compiler/pom.xml
+++ b/plexus-compiler-its/src/main/it/aspectj-compiler/pom.xml
@@ -31,13 +31,14 @@
     <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
     <maven.compiler.source>1.8</maven.compiler.source>
     <maven.compiler.target>1.8</maven.compiler.target>
+    <plexus.compiler.version>@pom.version@</plexus.compiler.version>
   </properties>
 
   <build>
     <plugins>
       <plugin>
         <artifactId>maven-compiler-plugin</artifactId>
-        <version>3.8.1</version>
+        <version>@maven.compiler.version@</version>
         <configuration>
           <compilerId>aspectj</compilerId>
         </configuration>
@@ -45,12 +46,12 @@
           <dependency>
             <groupId>org.codehaus.plexus</groupId>
             <artifactId>plexus-compiler-api</artifactId>
-            <version>@pom.version@</version>
+            <version>${plexus.compiler.version}</version>
           </dependency>
           <dependency>
             <groupId>org.codehaus.plexus</groupId>
             <artifactId>plexus-compiler-aspectj</artifactId>
-            <version>@pom.version@</version>
+            <version>${plexus.compiler.version}</version>
           </dependency>
         </dependencies>
       </plugin>
diff --git a/plexus-compiler-its/src/main/it/eclipse-compiler-mapstruct/pom.xml b/plexus-compiler-its/src/main/it/eclipse-compiler-mapstruct/pom.xml
index c72ca81e..39d0796b 100644
--- a/plexus-compiler-its/src/main/it/eclipse-compiler-mapstruct/pom.xml
+++ b/plexus-compiler-its/src/main/it/eclipse-compiler-mapstruct/pom.xml
@@ -34,7 +34,7 @@
     <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
     <maven.compiler.source>1.8</maven.compiler.source>
     <maven.compiler.target>1.8</maven.compiler.target>
-
+    <plexus.compiler.version>@pom.version@</plexus.compiler.version>
     <org.mapstruct.version>1.5.2.Final</org.mapstruct.version>
   </properties>
 
@@ -51,7 +51,7 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-compiler-plugin</artifactId>
-        <version>3.10.1</version>
+        <version>@maven.compiler.version@</version>
         <configuration>
           <compilerId>eclipse</compilerId>
         </configuration>
@@ -59,12 +59,12 @@
           <dependency>
             <groupId>org.codehaus.plexus</groupId>
             <artifactId>plexus-compiler-api</artifactId>
-            <version>@pom.version@</version>
+            <version>${plexus.compiler.version}</version>
           </dependency>
           <dependency>
             <groupId>org.codehaus.plexus</groupId>
             <artifactId>plexus-compiler-eclipse</artifactId>
-            <version>@pom.version@</version>
+            <version>${plexus.compiler.version}</version>
           </dependency>
           <dependency>
             <groupId>org.mapstruct</groupId>
diff --git a/plexus-compiler-its/src/main/it/error-prone-compiler/pom.xml b/plexus-compiler-its/src/main/it/error-prone-compiler/pom.xml
index 2722f0a9..47466656 100644
--- a/plexus-compiler-its/src/main/it/error-prone-compiler/pom.xml
+++ b/plexus-compiler-its/src/main/it/error-prone-compiler/pom.xml
@@ -32,6 +32,7 @@
   <properties>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <javac.version>9+181-r4173-1</javac.version>
+    <plexus.compiler.version>@pom.version@</plexus.compiler.version>
   </properties>
 
   <dependencies>
@@ -48,7 +49,7 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-compiler-plugin</artifactId>
-        <version>3.8.1</version>
+        <version>@maven.compiler.version@</version>
         <configuration>
           <target>8</target>
           <source>8</source>
diff --git a/plexus-compiler-its/src/main/it/missing-warnings/invoker.properties b/plexus-compiler-its/src/main/it/missing-warnings/invoker.properties
new file mode 100644
index 00000000..7265e231
--- /dev/null
+++ b/plexus-compiler-its/src/main/it/missing-warnings/invoker.properties
@@ -0,0 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+# 
+#   http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+invoker.java.version = 11+
+invoker.goals = clean compile
+#invoker.buildResult = failure
diff --git a/plexus-compiler-its/src/main/it/missing-warnings/pom.xml b/plexus-compiler-its/src/main/it/missing-warnings/pom.xml
new file mode 100644
index 00000000..42af0b33
--- /dev/null
+++ b/plexus-compiler-its/src/main/it/missing-warnings/pom.xml
@@ -0,0 +1,45 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+	<modelVersion>4.0.0</modelVersion>
+
+	<groupId>org.apache.maven.plugins.compiler.it</groupId>
+	<artifactId>missing-warnings</artifactId>
+	<version>1.0-SNAPSHOT</version>
+
+	<build>
+		<pluginManagement>
+			<plugins>
+				<plugin>
+					<groupId>org.apache.maven.plugins</groupId>
+					<artifactId>maven-compiler-plugin</artifactId>
+					<version>@maven.compiler.version@</version>
+					<configuration>
+						<forceJavacCompilerUse>true</forceJavacCompilerUse>
+						<showWarnings>true</showWarnings>
+					</configuration>
+					<dependencies>
+						<dependency>
+							<groupId>org.codehaus.plexus</groupId>
+							<artifactId>plexus-compiler-api</artifactId>
+							<version>${plexus.compiler.version}</version>
+						</dependency>
+						<dependency>
+							<groupId>org.codehaus.plexus</groupId>
+							<artifactId>plexus-compiler-javac</artifactId>
+							<version>${plexus.compiler.version}</version>
+						</dependency>
+					</dependencies>
+				</plugin>
+			</plugins>
+		</pluginManagement>
+	</build>
+
+	<properties>
+		<maven.compiler.source>11</maven.compiler.source>
+		<maven.compiler.target>11</maven.compiler.target>
+		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+		<plexus.compiler.version>@pom.version@</plexus.compiler.version>
+	</properties>
+</project>
\ No newline at end of file
diff --git a/plexus-compiler-its/src/main/it/missing-warnings/src/main/java/com/company/SomeClass.java b/plexus-compiler-its/src/main/it/missing-warnings/src/main/java/com/company/SomeClass.java
new file mode 100644
index 00000000..c0c65494
--- /dev/null
+++ b/plexus-compiler-its/src/main/it/missing-warnings/src/main/java/com/company/SomeClass.java
@@ -0,0 +1,5 @@
+package com.company;
+
+public class SomeClass
+{
+}
diff --git a/plexus-compiler-its/src/main/it/missing-warnings/src/main/java/module-info.java b/plexus-compiler-its/src/main/it/missing-warnings/src/main/java/module-info.java
new file mode 100644
index 00000000..0b7ef296
--- /dev/null
+++ b/plexus-compiler-its/src/main/it/missing-warnings/src/main/java/module-info.java
@@ -0,0 +1,3 @@
+module testcase {
+	exports com.company to someOtherModule;
+}
\ No newline at end of file
diff --git a/plexus-compiler-its/src/main/it/missing-warnings/verify.groovy b/plexus-compiler-its/src/main/it/missing-warnings/verify.groovy
new file mode 100644
index 00000000..6e9df7a4
--- /dev/null
+++ b/plexus-compiler-its/src/main/it/missing-warnings/verify.groovy
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+def logFile = new File( basedir, 'build.log' )
+assert logFile.exists()
+content = logFile.text.normalize()
+
+assert content.contains( "module-info.java:[2,24] [module] module not found: someOtherModule")
+//assert content.contains( "exports com.company to someOtherModule;" )
diff --git a/plexus-compiler-its/src/main/it/simple-eclipse-compiler-fail/pom.xml b/plexus-compiler-its/src/main/it/simple-eclipse-compiler-fail/pom.xml
index 5beaa3d0..03a77f48 100644
--- a/plexus-compiler-its/src/main/it/simple-eclipse-compiler-fail/pom.xml
+++ b/plexus-compiler-its/src/main/it/simple-eclipse-compiler-fail/pom.xml
@@ -34,6 +34,7 @@
     <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
     <maven.compiler.source>1.8</maven.compiler.source>
     <maven.compiler.target>1.8</maven.compiler.target>
+    <plexus.compiler.version>@pom.version@</plexus.compiler.version>
   </properties>
 
   <dependencies>
@@ -58,12 +59,12 @@
             <dependency>
             <groupId>org.codehaus.plexus</groupId>
             <artifactId>plexus-compiler-api</artifactId>
-            <version>@pom.version@</version>
+            <version>${plexus.compiler.version}</version>
           </dependency>
           <dependency>
             <groupId>org.codehaus.plexus</groupId>
             <artifactId>plexus-compiler-eclipse</artifactId>
-            <version>@pom.version@</version>
+            <version>${plexus.compiler.version}</version>
           </dependency>
         </dependencies>
       </plugin>
diff --git a/plexus-compiler-its/src/main/it/simple-eclipse-compiler/pom.xml b/plexus-compiler-its/src/main/it/simple-eclipse-compiler/pom.xml
index a4efe0c0..54694e38 100644
--- a/plexus-compiler-its/src/main/it/simple-eclipse-compiler/pom.xml
+++ b/plexus-compiler-its/src/main/it/simple-eclipse-compiler/pom.xml
@@ -34,6 +34,7 @@
     <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
     <maven.compiler.source>1.8</maven.compiler.source>
     <maven.compiler.target>1.8</maven.compiler.target>
+    <plexus.compiler.version>@pom.version@</plexus.compiler.version>
   </properties>
 
   <dependencies>
@@ -58,12 +59,12 @@
           <dependency>
             <groupId>org.codehaus.plexus</groupId>
             <artifactId>plexus-compiler-api</artifactId>
-            <version>@pom.version@</version>
+            <version>${plexus.compiler.version}</version>
           </dependency>
           <dependency>
             <groupId>org.codehaus.plexus</groupId>
             <artifactId>plexus-compiler-eclipse</artifactId>
-            <version>@pom.version@</version>
+            <version>${plexus.compiler.version}</version>
           </dependency>
         </dependencies>
       </plugin>
diff --git a/plexus-compiler-its/src/main/it/simple-javac-fork/pom.xml b/plexus-compiler-its/src/main/it/simple-javac-fork/pom.xml
index 054f42a6..d72b91ab 100644
--- a/plexus-compiler-its/src/main/it/simple-javac-fork/pom.xml
+++ b/plexus-compiler-its/src/main/it/simple-javac-fork/pom.xml
@@ -34,6 +34,7 @@
     <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
     <maven.compiler.source>11</maven.compiler.source>
     <maven.compiler.target>11</maven.compiler.target>
+    <plexus.compiler.version>@pom.version@</plexus.compiler.version>
   </properties>
 
   <dependencies>
@@ -50,7 +51,7 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-compiler-plugin</artifactId>
-        <version>3.8.1</version>
+        <version>@maven.compiler.version@</version>
         <configuration>
           <fork>true</fork>
           <compilerArgs>
@@ -61,12 +62,12 @@
             <dependency>
             <groupId>org.codehaus.plexus</groupId>
             <artifactId>plexus-compiler-api</artifactId>
-            <version>@pom.version@</version>
+            <version>${plexus.compiler.version}</version>
           </dependency>
           <dependency>
             <groupId>org.codehaus.plexus</groupId>
             <artifactId>plexus-compiler-javac</artifactId>
-            <version>@pom.version@</version>
+            <version>${plexus.compiler.version}</version>
           </dependency>
         </dependencies>
       </plugin>
diff --git a/plexus-compiler-its/src/main/it/simple-javac/pom.xml b/plexus-compiler-its/src/main/it/simple-javac/pom.xml
index 5c5efffc..a400f268 100644
--- a/plexus-compiler-its/src/main/it/simple-javac/pom.xml
+++ b/plexus-compiler-its/src/main/it/simple-javac/pom.xml
@@ -34,6 +34,7 @@
     <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
     <maven.compiler.source>1.8</maven.compiler.source>
     <maven.compiler.target>1.8</maven.compiler.target>
+    <plexus.compiler.version>@pom.version@</plexus.compiler.version>
   </properties>
 
   <dependencies>
@@ -50,22 +51,22 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-compiler-plugin</artifactId>
-        <version>3.8.1</version>
+        <version>@maven.compiler.version@</version>
         <configuration>
           <compilerArgs>
             <compilerArg>-Xlint:-path</compilerArg>
           </compilerArgs>
         </configuration>
         <dependencies>
-            <dependency>
+          <dependency>
             <groupId>org.codehaus.plexus</groupId>
             <artifactId>plexus-compiler-api</artifactId>
-            <version>@pom.version@</version>
+            <version>${plexus.compiler.version}</version>
           </dependency>
           <dependency>
             <groupId>org.codehaus.plexus</groupId>
             <artifactId>plexus-compiler-javac</artifactId>
-            <version>@pom.version@</version>
+            <version>${plexus.compiler.version}</version>
           </dependency>
         </dependencies>
       </plugin>
diff --git a/pom.xml b/pom.xml
index f61a59cd..e167a988 100644
--- a/pom.xml
+++ b/pom.xml
@@ -54,6 +54,7 @@
     <errorprone.version>2.14.0</errorprone.version>
     <trimStackTrace>false</trimStackTrace>
     <preparationGoals>clean install</preparationGoals>
+    <maven.compiler.version>3.10.1</maven.compiler.version>
   </properties>
 
   <dependencyManagement>
@@ -129,6 +130,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-compiler-plugin</artifactId>
+          <version>${maven.compiler.version}</version>
           <configuration>
             <release>8</release>
           </configuration>