Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Virtualized select component #279

Closed
wants to merge 2 commits into from
Closed

WIP: Virtualized select component #279

wants to merge 2 commits into from

Conversation

timtraversy
Copy link
Contributor

@alexjball This is almost there but there are some bugs I don't understand:

  1. When you make a selection, the select component doesn't display the selection.
  2. Every few loads of the page, I'm getting a 5000 ms timeout from the state or occupation fetch. Could just be a Docker thing, but I'd like to see if other people are getting the same thing.

@alexjball
Copy link
Member

Hey Tim, the state/occupation fetches work consistently against the deployed backend. I haven't observed issues under Docker either but I could be misremembering.

@alexjball alexjball linked an issue Feb 17, 2021 that may be closed by this pull request
Use a virtualized list for select components #244
Open
@alexjball
Copy link
Member

Going to close this. We can revisit using a virtualized list once we start building the smart search UI.

@alexjball alexjball closed this Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a virtualized list for select components
2 participants
@timtraversy @alexjball