Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TLS for UNIX Sockets via Env Var #546

Merged
merged 1 commit into from
May 5, 2017

Conversation

akutz
Copy link
Collaborator

@akutz akutz commented May 5, 2017

This patch provides a way to reenable TLS for UNIX sockets by setting the environment variable LIBSTORAGE_TLS_SOCKITTOME to a truthy value.

@akutz akutz self-assigned this May 5, 2017
@akutz akutz requested a review from codenrhoden May 5, 2017 15:14
@codecov-io
Copy link

codecov-io commented May 5, 2017

Codecov Report

Merging #546 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
- Coverage    28.4%   28.32%   -0.09%     
==========================================
  Files          34       34              
  Lines        2003     2009       +6     
==========================================
  Hits          569      569              
- Misses       1373     1379       +6     
  Partials       61       61
Impacted Files Coverage Δ
api/utils/utils_tls.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d0eb86...7f9099f. Read the comment docs.

@akutz akutz force-pushed the feature/env-var-tls-sock branch from 114e039 to 7f9099f Compare May 5, 2017 15:22
This patch provides a way to reenable TLS for UNIX sockets by
setting the environment variable `LIBSTORAGE_TLS_SOCKITTOME` to
a truthy value.
Copy link
Contributor

@codenrhoden codenrhoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate the great explanation in the docs of what's going on, and why.

The code changes look good.

@akutz akutz merged commit c6a8530 into thecodeteam:master May 5, 2017
@akutz akutz deleted the feature/env-var-tls-sock branch May 5, 2017 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants