Path Enhancements #509
Merged
Path Enhancements #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch enhances the way libStorage manages its internal file path
workflow.
* There is a new path constant, "TLS". It's default path is
"/etc/libstorage/tls".
* When LIBSTORAGE_HOME is set the path structure removes the nested
"libstorage" element. For example, while the default configuration
directory is "/etc/libstorage", now if LIBSTORAGE_HOME is set to
"/tmp/libstorage" the new configuration directory path will be
"/tmp/libstorage/etc" instead of "/tmp/libstorage/etc/libstorage".
* All path constants can now be explicitly specified via environment
variables, independent of the value of LIBSTORAGE_HOME. For example,
if LIBSTORAGE_HOME is set to "/tmp/libstorage", LIBSTORAGE_PATHS_ETC
can be set to "/etc/libstorage" to ensure that the configuration
directory is not nested inside of LIBSTORAGE_HOME. Available
environment variables are:
* LIBSTORAGE_PATHS_ETC
* LIBSTORAGE_PATHS_LIB
* LIBSTORAGE_PATHS_LOG
* LIBSTORAGE_PATHS_RUN
* LIBSTORAGE_PATHS_TLS
* LIBSTORAGE_PATHS_LSX
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
=========================================
+ Coverage 30.21% 30.82% +0.6%
=========================================
Files 34 33 -1
Lines 1959 2008 +49
=========================================
+ Hits 592 619 +27
- Misses 1303 1317 +14
- Partials 64 72 +8
Continue to review full report at Codecov.
|
codenrhoden
approved these changes
Apr 12, 2017
| return "/var/run/libstorage" | ||
| case TLS: | ||
| return "tls" |
There was a problem hiding this comment.
Why is TLS different from the others, and not ever dependent on LIBSTORAGE_HOME ?
There was a problem hiding this comment.
Hi @codenrhoden,
Because of the function parent:
func (k fileKey) parent() fileKey {
switch k {
case TLS:
return Etc
case LSX:
return Lib
default:
return Home
}
}Unless specified by an env var, the TLS path is relative to the Etc path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enhances the way libStorage manages its internal file path workflow.
There is a new path constant,
TLS. It's default path is/etc/libstorage/tls.When
LIBSTORAGE_HOMEis set the path structure removes the nestedlibstorageelement. For example, while the default configuration directory is/etc/libstorage, now ifLIBSTORAGE_HOMEis set to/tmp/libstoragethe new configuration directory path will be/tmp/libstorage/etcinstead of/tmp/libstorage/etc/libstorage.All path constants can now be explicitly specified via environment variables, independent of the value of
LIBSTORAGE_HOME. For example, ifLIBSTORAGE_HOMEis set to/tmp/libstorage,LIBSTORAGE_PATHS_ETCcan be set to/etc/libstorageto ensure that the configuration directory is not nested inside ofLIBSTORAGE_HOME. Available environment variables are:LIBSTORAGE_PATHS_ETCLIBSTORAGE_PATHS_LIBLIBSTORAGE_PATHS_LOGLIBSTORAGE_PATHS_RUNLIBSTORAGE_PATHS_TLSLIBSTORAGE_PATHS_LSX