Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Remove unnecessary dependency for ruby standard gem #105

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

uplus
Copy link
Contributor

@uplus uplus commented Oct 12, 2020

I want to reduce unnecessary dependency from my product's Gemfile.lock.
The json gem is contained in the ruby standard gems.
They get automatically installed when you install Ruby.

The following Gemfile.lock is minimum project example that using codecov.

Gemfile.lock (before this PR)

GEM
  remote: https://rubygems.org/
  specs:
    codecov (0.2.12)
      json
      simplecov
    docile (1.3.2)
    json (2.3.1)
    simplecov (0.19.0)
      docile (~> 1.1)
      simplecov-html (~> 0.11)
    simplecov-html (0.12.3)

PLATFORMS
  ruby

DEPENDENCIES
  codecov

BUNDLED WITH
   2.1.4

Gemfile.lock (after this PR)

GEM
  remote: https://rubygems.org/
  specs:
    docile (1.3.2)
    simplecov (0.19.0)
      docile (~> 1.1)
      simplecov-html (~> 0.11)
    simplecov-html (0.12.3)

PLATFORMS
  ruby

DEPENDENCIES
  codecov

BUNDLED WITH
   2.1.4

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #105 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files           1        1           
  Lines         356      356           
=======================================
  Hits          327      327           
  Misses         29       29           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e3dae3...0560642. Read the comment docs.

Copy link
Contributor

@thomasrockhu thomasrockhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @uplus !

@thomasrockhu thomasrockhu merged commit 40ff7cc into codecov:master Oct 13, 2020
@uplus uplus deleted the remove-json-dependency branch October 13, 2020 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants