You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
I'm not sure how this could conflict with the existing -f argument if globbing is used in (the -f') arg. Do take note of the comment for -fin the screenshot above with respect to this:
This is non-exclusive, use -s "*.foo" to match specific paths.
so I'm not sure if this means globbing should be removed from -f ??
The text was updated successfully, but these errors were encountered:
@PureKrome I assume that you are talking about the functionality of them in codecov-bash. Unfortunately, I can not confirm what the functionality is there.
I can tell you what my impression of the functionality in that script though:
-f in codecov-bash under my impression adds additional files to their internal default list of files that it will use if they exist.
-s seems to be twofold in codecov-bash.
It can be the base of the directories to search for coverage files.
It overrides the -f and the internal files if a full path to a file, or a globbing pattern matching files are used.
Now, what the -f do here in codecov-exe and what I expect the -s argument to do is somewhat diferrent
-f in codecov-exe is the explicit files to upload, this must exist, or the program will throw an error (we also don't use any internal list of default files).
-s would be expected to be either a full path to a directory, or a globbing pattern matching directories that should be used as base directories for any relative paths specified with the -f argument.
@PureKrome yes, exactly like that is what I envision (although, there is a need to quote the argument value to if the user would like the program instead of the shell to expand the globbing pattern).
also, do you want -f to do globbing also?
Yes, -f should still allow for globbing, both when used alone and used together with -s (although this would be in conflict with codecov-bash).
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As requested in #53 the codecov-bash script accepts a
-s
argument:From the codecov-bash script:
I'm not sure how this could conflict with the existing
-f
argument ifglobbing
is used in (the-f'
) arg. Do take note of the comment for-f
in the screenshot above with respect to this:so I'm not sure if this means
globbing
should be removed from-f
??The text was updated successfully, but these errors were encountered: