Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "working-directory:" input #110

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Conversation

khaeru
Copy link
Contributor

@khaeru khaeru commented Aug 12, 2020

This PR adds an input working-directory:, the same name as GitHub Actions uses for generic (run:) steps: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstepsrun

The value is passed to the cwd option of GitHub's @actions/exec exec() method:
https://github.com/actions/toolkit/blob/d9347d4ab99fd507c0b9104b2cf79fb44fcc827d/packages/exec/src/interfaces.ts#L5-L7

This allows the user to specify in which directory codecov.sh should run.

Other information:

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #110 (c770ad4) into master (beb5a96) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files           2        2           
  Lines          16       16           
  Branches        2        2           
=======================================
  Hits           14       14           
  Misses          2        2           
Flag Coverage Δ
unittest 87.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beb5a96...c770ad4. Read the comment docs.

@thomasrockhu
Copy link
Contributor

@khaeru, if you resolve the conflicts, I'll take a look at merging this in.

@thomasrockhu thomasrockhu self-requested a review December 9, 2020 16:33
@khaeru
Copy link
Contributor Author

khaeru commented Dec 15, 2020

Rebased.

@thomasrockhu thomasrockhu merged commit 09facdb into codecov:master Dec 16, 2020
This was referenced Mar 10, 2021
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants