-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "working-directory:" input #110
Conversation
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=======================================
Coverage 87.50% 87.50%
=======================================
Files 2 2
Lines 16 16
Branches 2 2
=======================================
Hits 14 14
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@khaeru, if you resolve the conflicts, I'll take a look at merging this in. |
Rebased. |
This PR adds an input
working-directory:
, the same name as GitHub Actions uses for generic (run:
) steps: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstepsrunThe value is passed to the
cwd
option of GitHub's @actions/exec exec() method:https://github.com/actions/toolkit/blob/d9347d4ab99fd507c0b9104b2cf79fb44fcc827d/packages/exec/src/interfaces.ts#L5-L7
This allows the user to specify in which directory codecov.sh should run.
Other information:
yml
optional input doesn't seem to be working #51 (comment) —this PR differs because it is not trying to address the deprecated/removed-y
option tocodecov.sh
, but rather allow configuration of the directory in which the program is executed.yml
optional input doesn't seem to be working #51) to "place codecov.yml at the root of the repository" only covers a subset of possible workflows. This is because GitHub's provided Checkout action has apath:
option that controls where each repository is checked out. $GITHUB_WORKSPACE (where this action currently always executes) will be a different directory from "the root of the repository" any timepath:
is used; this is common when a workflow checks out two or more repositories. This PR removes this restriction.