Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: session typing #3899

Merged
merged 2 commits into from
Oct 6, 2023
Merged

fix: session typing #3899

merged 2 commits into from
Oct 6, 2023

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

  • Most of the time, we are using session without returning anything so this PR to get rid of complaining when using session without await.

Type of change

  • 🐛 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent added the typescript Changes for typings or typescript compatibility label Sep 28, 2023
@kobenguyent kobenguyent merged commit 3358929 into 3.x Oct 6, 2023
8 checks passed
@kobenguyent kobenguyent deleted the fix-session-typings branch October 6, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell approved these changes

Assignees
No one assigned
Labels
typescript Changes for typings or typescript compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobenguyent @Arhell