Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update change notification email fields to include all tsml_export_columns. #1455

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

gobborg
Copy link
Collaborator

@gobborg gobborg commented Jun 23, 2024

In the existing code, timezone and conference information are not included in the change notification email fields.
image

With this patch, timezone and conference information are included in the change notification email fields. Using the $tsml_export_columns variable future proofs it for further updates.
image

@gobborg gobborg linked an issue Jun 23, 2024 that may be closed by this pull request
includes/save.php Outdated Show resolved Hide resolved
includes/save.php Outdated Show resolved Hide resolved
@gkovats gkovats changed the title Update change notification email fields to include all tsml_export_coumns. Update change notification email fields to include all tsml_export_columns. Oct 19, 2024
@joshreisner joshreisner self-assigned this Nov 2, 2024
@joshreisner joshreisner requested a review from gkovats November 2, 2024 02:10
@joshreisner
Copy link
Contributor

so this is working great except when a field goes from empty to filled, it sees the $old value as the new value

Screenshot 2024-11-01 at 7 09 28 PM

i think it has to do with timing and might require a bigger refactor

@joshreisner joshreisner marked this pull request as draft November 2, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants