Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify is sent before deploy itself #7

Open
jakoss opened this issue Aug 20, 2018 · 1 comment
Open

Notify is sent before deploy itself #7

jakoss opened this issue Aug 20, 2018 · 1 comment

Comments

@jakoss
Copy link

jakoss commented Aug 20, 2018

I have this deploy config:

require 'mina/bundler'
require 'mina/rails'
require 'mina/git'
require 'mina/rvm'
require 'mina/rollbar'

set :shared_dirs, fetch(:shared_dirs, []).push("public/uploads").push("log")
set :current_path, 'public_ruby'
set :term_mode, nil
set :rollbar_access_token, 'TOKEN' 

task :remote_environment do
  invoke :'rvm:use', '2.5.0'
end

# staging and production data

task :deploy do
  deploy do
    invoke :'git:clone'
    invoke :'deploy:link_shared_paths'
    invoke :'bundle:install'
    invoke :'rails:assets_precompile'
    invoke :'deploy:cleanup'

    on :launch do
      invoke :restart
      invoke :'rollbar:notify'
    end
  end
end

The problem is we are getting slack notify immediately after deploy start (Before even git:clone starts). No matter if deploy failed or succeeded. It's super odd. Have you any ideas or tips how to approach to this?

Versions:
mina: 1.2.3
mina-rollbar: 1.0.1

@edit: Notification get sent even if i run simulation deploy with -s flag!

@jakoss
Copy link
Author

jakoss commented Aug 20, 2018

Ok, i found out that you migrated from curl to notify in ruby in this commit 921baa2

It's cool and all, but it destroy whole deploy flow. There is effectively no point in notifying about deploy before it even starts..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant