Add support for Subscription Schedules #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maartenvanvliet Is it possible to test yet with stripe-mock? Or do we need to update some deps? |
|
I will add some tests to this PR. It will depend on #485 because of a more recent version of stripe-mock |
maartenvanvliet
force-pushed
the
issues/subscription_schedule
branch
from
8ad66eb to
4d9dfde
Compare
|
Looks like we got a bunch of PR's merged in from @maartenvanvliet! Thanks a ton. Will release a minor version after this PR is in. |
maartenvanvliet
force-pushed
the
issues/subscription_schedule
branch
from
4d9dfde to
212c157
Compare
|
👍 |
snewcomer
reviewed
May 24, 2019
|
|
||
| """ | ||
| @spec create(params, Stripe.options()) :: {:ok, t} | {:error, Stripe.Error.t()} | ||
| when params: %{ |
There was a problem hiding this comment.
@maartenvanvliet Last question before we merge - how did you know what params go with the create action?
There was a problem hiding this comment.
https://raw.githubusercontent.com/stripe/openapi/master/openapi/spec3.yaml and access to the beta
There was a problem hiding this comment.
Great! Nice work! Just saving a mental note to look at again once out of beta. 👍
maartenvanvliet
commented
May 24, 2019
jalexander
pushed a commit
to Frameio/stripity_stripe
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Subscription Schedules. It is still in beta but already available in the OpenAPI spec https://github.com/stripe/openapi/blob/master/openapi/fixtures3.yaml#L2088 and other Stripe API clients e.g. stripe/stripe-ruby@d784819