fix typespec for date query to make keys optional #421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hi!
Many thanks for building and maintaining
stripity_stripe
. It makes integrating with Stripe really nice. I noticed that when I pulled it into my project I started to get a dialyzer error because I was doing a query likeStripe.Event.list(%{created: %{gt: timestamp}, limit: 50, starting_after: cursor}, api: api_key)
The call above works just fine, but dialyzer is throwing an error because the typespec for the datequery specifies all 4 keys of
gt
,gte
,lt
,lte
. Putting all of them right into the typespec will treat them as required keys. So I just changed the typespec to make each of those keys optional the way they are documented in the stripe api.