Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 "Export settings" file is not saved as improvedtube.json and is instead saved as a hidden file. #2770

Open
5HT2 opened this issue Jan 9, 2025 · 3 comments
Assignees
Labels
Bug Bug or required update after YouTube changes Completion to revise (rethink, improve, tweak) (this feature or structure) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ z macOS

Comments

@5HT2
Copy link
Member

5HT2 commented Jan 9, 2025

Concise Description

Save window after exporting
Breakpoint stopped here
The hidden files that did export

Browser/s

Chrome

Other Browser:

No response

'Steps to reproduce' - Which of our features is required for the bug to happen?

Attempt to export your configuration

Since when?

I have not encountered this before

Does the bug still happen when you log out of YouTube?

Yes

..No? Then please paste your yt.config_.EXPERIMENT_FLAGS. Twice (With the error & Without)

No response

Are any errors or related log-messages shown in the Browser-Console? (F12)

No, included in screenshot.

Tested as the only active extension? (incognito mode or another browser users):

None

Expected preferred behavior:

No response

ImprovedTube Version

4.1188

Your Settings (From the Extension's -Hamburger menu > Settings > Backup & reset > Export settings)

Unfortunately the issue affects my ability to do this, but they only cosmetic (player / appearance sections).

Your YouTube-Document

Is this necessary at this time?

OS / Device:

macOS 14.6.1 - Apple M1 Pro

@5HT2 5HT2 added Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Jan 9, 2025
@5HT2
Copy link
Member Author

5HT2 commented Jan 9, 2025

Actually, I forgot to include this initially, but before I initially granted the permission I could actually see a native OS filepicker window to save the file come up - it looks like the fact that the window is closed too quickly to react normally (since I never confirmed the filename inside of the native OS save picker), it will continue saving with an auto-generated name.

@ImprovedTube ImprovedTube added Completion to revise (rethink, improve, tweak) (this feature or structure) z Safari occuring in Safari (only?) z macOS and removed z Safari occuring in Safari (only?) labels Jan 9, 2025
@ImprovedTube
Copy link
Member

hi! and thanks @5HT2 sounds like you should be (like you are almost) part of our list of contributors

@5HT2
Copy link
Member Author

5HT2 commented Jan 10, 2025

It looks like this bug in Chrome is relevant: https://issues.chromium.org/issues/40258993

Archived bug with a better explanation: https://issues.chromium.org/issues/40453079

It has to do with multiple extensions having event listeners attached to chrome.downloads.onDeterminingFilename.addListenerchrome.downloads.onDeterminingFilename.addListener.

I would suggest maybe we can try disabling saveAs and just let it save in the default Downloads folder without prompt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes Completion to revise (rethink, improve, tweak) (this feature or structure) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ z macOS
Projects
None yet
Development

No branches or pull requests

2 participants