Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

menu/index.html extra quotation #2693

Closed
peterdanwan opened this issue Nov 27, 2024 · 1 comment · Fixed by #2694
Closed

menu/index.html extra quotation #2693

peterdanwan opened this issue Nov 27, 2024 · 1 comment · Fixed by #2694
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@peterdanwan
Copy link
Contributor

peterdanwan commented Nov 27, 2024 •
edited
Loading

Bug Report:

  • Description:
    menu/index.html has an extra quotation within it:

    unnecessary-quotation

  • Steps to reproduce this::

    • Visit menu/index.html (should be underlined)

  • Since when?:

  • Browser:

    • N/A

  • Are any errors shown in the Browser-Console?: (F12-key, then console-tab)

    • Errors show on VSCode

  • Does the bug not happen when you log out of YouTube? Then please copy your experiment flags list twice (with & without the error to compare). Enter: yt.config_.EXPERIMENT_FLAGS into the Browser console on youtube (F12-Key - Or find it in the html source(ctrl+U)

    • Problem shows within an editor, (don't know the exact repercussions on the extension itself)
please check, if the issue has already been reported ever. (If so, that might inspires you to add different/better words to that report.)

GitHub's issue search (use the link or remove "is:issue is:open" from the search)

  • Expected preferred behavior:
    • The quotation is removed, so the file has no linting errors
  • ImprovedTube Version (Written in the Extension header & your Browser's store)
  • Tested as only active extension or in incognito mode?: N/A
  • Your Settings (From the Extension's ⋮-Hamburger menu > Settings > Backup & reset > Export settings (You can remove any Blocklist, History Analyzer data - or paste the following in the Browser-Console and hit enter: (function({analyzer, blocklist, ...a}){return JSON.stringify(a)})(ImprovedTube.storage) ) N/A
  • YouTube-Document: (F12 copy the whole root element: <html> (alternative: CTRL+U) (https://github.com/code-charity/youtube/wiki/Contributing#Test ) N/A
  • OS / Device: Windows 11 OS
@peterdanwan peterdanwan added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Nov 27, 2024
@peterdanwan
Copy link
Contributor Author

I can work on this while I work on #2634!

@peterdanwan peterdanwan mentioned this issue Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove extra quotation peterdanwan/youtube
1 participant
@peterdanwan