Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoplay not working 4.940 #2426

Closed
Evoden1 opened this issue Jun 30, 2024 · 1 comment
Closed

Autoplay not working 4.940 #2426

Evoden1 opened this issue Jun 30, 2024 · 1 comment
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@Evoden1
Copy link

Evoden1 commented Jun 30, 2024

Bug Report:

  • Description: The videos now don't play at all. There is a YouTube logo in the middle of the video, and when I click it/spacebar, nothing happens. Something is wrong with autoplay.
  • Steps to reproduce this: just download @Raszpl Release Nr.4
  • Since when?: i just tried updating the extension today
  • Browser: Firefox Nightly, Edge and Chrome all don't work
  • Are any errors shown in the Browser-Console?: Uncaught SyntaxError: missing ) after condition player.js:18:102
Uncaught TypeError: this.playerSDR is not a function
   init moz-extension://bcc6e4f9-1a5b-40cb-b159-24ac6b48b1be/js&css/web-accessible/init.js:103
   <anonymous> moz-extension://bcc6e4f9-1a5b-40cb-b159-24ac6b48b1be/js&css/web-accessible/core.js:176
init.js:103:7
  • Does the bug not happen when you log out of YouTube? logged in and logged out it still happens in both

Also

The first error is just missing a ), but it still doesn't fix the problem, I think.

I found it when I commented out this.playerOnPlay() in init.js.
The autoplay problem is gone.

So is there something wrong with the function playerOnPlay() in function.js?

OPTIONAL (usually): -->
@Evoden1 Evoden1 added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Jun 30, 2024
@ImprovedTube
Copy link
Member

hi! and thanks @Evoden1 my bad! (#2397) just updated the release late. now.
The same (without the bug) was sent to stores 1 week ago.

yet again, the latest additions, fixes for shortcuts, are still not tested. Hoping to upload them these days too,
so if you want to check that might helps. #2421 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ImprovedTube @Evoden1