Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini player bug #2011

Open
GKid94 opened this issue Feb 13, 2024 · 8 comments
Open

Mini player bug #2011

GKid94 opened this issue Feb 13, 2024 · 8 comments
Labels
Completion to revise (rethink, improve, tweak) (this feature or structure) CSS Solution can be CSS? else please specify (JS might only be needed to inject the CSS) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@GKid94
Copy link

GKid94 commented Feb 13, 2024

The mini player opens when you still see the normal player
Screenshot 2024-02-13 185352

@GKid94 GKid94 added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Feb 13, 2024
@ImprovedTube
Copy link
Member

hi! @GKid94 always? did you notice when/why something changed?

@shubhamsk07
Copy link

can you give steps to reproduce the bug. as in my browsers its working normally.

@GKid94
Copy link
Author

GKid94 commented Feb 15, 2024

hi! @GKid94 always? did you notice when/why something changed?

Yes, I just recently installed the extension
Screenshot 2024-02-15 223737

@GKid94
Copy link
Author

GKid94 commented Feb 15, 2024

can you give steps to reproduce the bug. as in my browsers its working normally.

Enable custom mini player in ImprovedYouTube extension, refresh a video page and scroll down

@GKid94
Copy link
Author

GKid94 commented Feb 19, 2024

Still broken on version 4.642

@ImprovedTube
Copy link
Member

hi @GKid94! I wonder if this results from somebody's changes several month ago. If a bug is our's (not just happening after a youtube update), then you can conveniently track exactly where it started at https://addons.mozilla.org/en-US/firefox/addon/youtube-addon/versions/ (with firefox).

(

  • Go back 2 years.
    • If the bug is still there: report (probably not caused by us then)
    • Or If it works 2 years ago, check 1 year ago
      • If it still works check 0.5 years ago
      • or if it is broken 1 year ago, then go back to 1.5 years ago
        • and ... 0.25 1.75
          • so
            • on
              )

@GKid94
Copy link
Author

GKid94 commented Feb 20, 2024

hi @GKid94! I wonder if this results from somebody's changes several month ago. If a bug is our's (not just happening after a youtube update), then you can conveniently track exactly where it started at https://addons.mozilla.org/en-US/firefox/addon/youtube-addon/versions/ (with firefox).

(

  • Go back 2 years.

    • If the bug is still there: report (probably not caused by us then)

    • Or If it works 2 years ago, check 1 year ago

      • If it still works check 0.5 years ago

      • or if it is broken 1 year ago, then go back to 1.5 years ago

        • and ... 0.25 1.75

          • so

            • on
              )

I don't know when it started but the Enhancer for YouTube doesn't have that problem
Screenshot 2024-02-20 204854

@ImprovedTube
Copy link
Member

  • we can come up with an animation making it smoother

it always was set to appear once scrolled down >=256pixel

  • (we could be more precise: 50% of the video or x% of screen)
  • unlikely to scroll far by mistake and undo in the same second.
    • is there anything inbetween wanting this and not?
  • you can drag and drop the mini player to the same position as the player but half the size or so, then it might make most sense to you

@ImprovedTube ImprovedTube added Completion to revise (rethink, improve, tweak) (this feature or structure) CSS Solution can be CSS? else please specify (JS might only be needed to inject the CSS) and removed Bug Bug or required update after YouTube changes labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completion to revise (rethink, improve, tweak) (this feature or structure) CSS Solution can be CSS? else please specify (JS might only be needed to inject the CSS) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

3 participants