-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hover the header on video page dont hide it entirely... #1823
Comments
with (the header also appears in grey for a moment while YouTube is loading) |
For me its a black strip on all the option u pointed out |
assign |
hi! @gouravmpk thanks for caring |
Can I have some screen shot of the screen to understand the issue more clearly |
hi @gouravmpk this is all about
( Same applies to the options ( The player size feature also used to react to the sidebar or related videos being hidden. We could fix that too or restructure or rename the the whole feature/s maybe, based on user needs ) |
about animation. Its actually cool, if theres a way to remain it even with removing the gap it would be cool. I know you think is unnecesery, but i think its really fine ^^ |
So you (still) like the animation? because you don't need it every time? Just assuming fading in might become the first one listed. To save user's attention(=time). - Won't mind hoarding both of course. (Renaming |
What do you mean? I would like gap to dissapear, but showing and hiding animation has nothing to do with gap |
Hope the (optional!) complexity didn't overwhelm you @gouravmpk!
still just thought fading in from transparent is more calm and might take a line of code less as said, hence expecting both options. While one issue at a time is enough, one cant only care for half a feature. It might be efficient to try to consider the road-net ahead and one can end up fixing two things at once just with the same effort and commenting/planing/helping a 3rd one. |
Oh i find something interesting that is cool. I u have header hidden on video page, u can still went into finding it clicking "go to search box" shortcut. Just addition, it would be cool if you would add explaination in that option. Cause im using your extension for a looong time and finding this only now xD Oh and u cant do that on non-video pages somehow |
let's add a tooltip. I think you nearly earned a PR 🤣
can you check for error? do other features als stop working on non-video pages? |
@ImprovedTube After new update, the top black space is nowhere to be found, but theres another issue... When im changing my uption to "hover" my entire page is slighty moved up, and even usin "full height" option is leaving ha bar with title on a bottom. I need to investigate more tho, but u can try to reproduce it. My settighs are here: improvedtube (5).zip |
oh and after ecent update scrollbars cant be hidden. Somehow any of extensions i got to do that, stopped working. Illl made new issue. |
right, we need to tune one more variable #2027 |
Emmm... top black bar™️ returned @ImprovedTube |
is this issue is closed ? |
hi! @AyushBarai no, just tried the one variable and undid. |
@ImprovedTube After new update on Chrome Webstore for beta(4.928) header is fully hidden, but using its still causing to player not being on full height, even if player size is set to full height. |
PS. Its a little bit smaller when u scale page to be smaller 🤷 |
I can suggest to make additional option that u can turn on, ane then u can choose the header behaviour seperatly for home page and video page. |
which two will you chose? |
What do you mean exactly? |
...and it can be easly seen when u use theatre mode with "full window" player size option
I checked, header is dissapiring but its box its still seen. Probably cause place when box moving is aligned to the centre of height of a box not a bottom of it, and it working only like that on a video page cause i think main page works good.
The text was updated successfully, but these errors were encountered: