-
Notifications
You must be signed in to change notification settings - Fork 2
/
Copy pathCalldataList.t.sol
1167 lines (985 loc) · 39.5 KB
/
CalldataList.t.sol
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
pragma solidity 0.8.25;
import {IERC1155Receiver} from
"@openzeppelin-contracts/contracts/token/ERC1155/IERC1155Receiver.sol";
import {IERC721Receiver} from
"@openzeppelin-contracts/contracts/token/ERC721/IERC721Receiver.sol";
import {
IERC165,
ERC165
} from "@openzeppelin-contracts/contracts/utils/introspection/ERC165.sol";
import {Test, console} from "forge-std/Test.sol";
import {Timelock} from "src/Timelock.sol";
import {MockSafe} from "test/mock/MockSafe.sol";
import {MockLending} from "test/mock/MockLending.sol";
contract CalldataListUnitTest is Test {
struct CheckData {
address[] targets;
bytes4[] selectors;
uint16[] startIndexes;
uint16[] endIndexes;
bytes[][] calldatas;
}
/// @notice struct used to fuzz values for testAddAndRemoveCalldataFuzzy
/// target: the contract address to be whitelisted
/// selector: the function signature to be whitelisted on target contract
/// calldataLength: length of calldata for all the checks for target and selector
/// seedCalldata: seed calldata used to generate multiple calldatas for different AND and OR checks
struct CheckDataFuzzParams {
address target;
bytes4 selector;
uint16 calldataLength;
bytes seedCalldata;
}
/// @notice reference to the Timelock contract
Timelock private timelock;
/// @notice reference to the MockSafe contract
MockSafe private safe;
/// @notice reference to the MockLending contract
MockLending private lending;
/// @notice the 3 hot signers that can execute whitelisted actions
address[] public hotSigners;
/// @notice address of the guardian that can pause in case of emergency
address public guardian = address(0x11111);
/// @notice duration of pause
uint128 public constant PAUSE_DURATION = 10 days;
/// @notice minimum delay for a timelocked transaction in seconds
uint256 public constant MINIMUM_DELAY = 2 days;
/// @notice expiration period for a timelocked transaction in seconds
uint256 public constant EXPIRATION_PERIOD = 5 days;
/// @notice addresses of the hot signers
address public constant HOT_SIGNER_ONE = address(0x11111);
address public constant HOT_SIGNER_TWO = address(0x22222);
address public constant HOT_SIGNER_THREE = address(0x33333);
/// @notice nonce for generating random numbers
uint256 internal _nonce = 0;
/// @notice mapping used in testAddAndRemoveCalldataFuzzy to store
/// total number of AND checks for a contract selector pair
mapping(address target => mapping(bytes4 selector => uint256 count)) private
totalChecks;
function setUp() public {
hotSigners.push(HOT_SIGNER_ONE);
hotSigners.push(HOT_SIGNER_TWO);
hotSigners.push(HOT_SIGNER_THREE);
// at least start at unix timestamp of 1m so that block timestamp isn't 0
vm.warp(block.timestamp + 1_000_000);
safe = new MockSafe();
lending = new MockLending();
// Assume the necessary parameters for the constructor
timelock = new Timelock(
address(safe), // _safe
MINIMUM_DELAY, // _minDelay
EXPIRATION_PERIOD, // _expirationPeriod
guardian, // _pauser
PAUSE_DURATION, // _pauseDuration
hotSigners
);
timelock.initialize(
new address[](0),
new bytes4[](0),
new uint16[](0),
new uint16[](0),
new bytes[][](0)
);
}
function testSetup() public view {
for (uint256 i = 0; i < hotSigners.length; i++) {
assertTrue(
timelock.hasRole(timelock.HOT_SIGNER_ROLE(), hotSigners[i]),
"hot signer not assigned"
);
}
}
function testAddCalldataCheckAndRemoveCalldataCheckSucceeds() public {
address[] memory targetAddresses = new address[](3);
targetAddresses[0] = address(lending);
targetAddresses[1] = address(lending);
targetAddresses[2] = address(lending);
bytes4[] memory selectors = new bytes4[](3);
selectors[0] = MockLending.deposit.selector;
selectors[1] = MockLending.deposit.selector;
selectors[2] = MockLending.deposit.selector;
/// compare first 20 bytes
uint16[] memory startIndexes = new uint16[](3);
startIndexes[0] = 16;
startIndexes[1] = 16;
startIndexes[2] = 40;
uint16[] memory endIndexes = new uint16[](3);
endIndexes[0] = 36;
endIndexes[1] = 36;
endIndexes[2] = 60;
bytes[][] memory checkedCalldatas = new bytes[][](3);
bytes[] memory checkedCalldata1 = new bytes[](1);
checkedCalldata1[0] = abi.encodePacked(address(this));
checkedCalldatas[0] = checkedCalldata1;
bytes[] memory checkedCalldata2 = new bytes[](1);
checkedCalldata2[0] = abi.encodePacked(address(timelock));
checkedCalldatas[1] = checkedCalldata2;
bytes[] memory checkedCalldata3 = new bytes[](1);
checkedCalldata3[0] = abi.encodePacked(address(timelock));
checkedCalldatas[2] = checkedCalldata3;
vm.prank(address(timelock));
timelock.addCalldataChecks(
targetAddresses,
selectors,
startIndexes,
endIndexes,
checkedCalldatas
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
).length,
2,
"calldata checks not added"
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
)[0].dataHashes.length,
2,
"calldata checks not added"
);
vm.prank(address(timelock));
timelock.removeCalldataCheck(
address(lending), MockLending.deposit.selector, 0
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
).length,
1,
"calldata check not removed"
);
vm.prank(address(timelock));
timelock.removeCalldataCheck(
address(lending), MockLending.deposit.selector, 0
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
).length,
0,
"calldata check not removed"
);
}
function testAddCalldataCheckAndRemoveCalldataCheckDatahashSucceeds()
public
{
address[] memory targetAddresses = new address[](2);
targetAddresses[0] = address(lending);
targetAddresses[1] = address(lending);
bytes4[] memory selectors = new bytes4[](2);
selectors[0] = MockLending.deposit.selector;
selectors[1] = MockLending.deposit.selector;
/// compare first 20 bytes
uint16[] memory startIndexes = new uint16[](2);
startIndexes[0] = 16;
startIndexes[1] = 16;
uint16[] memory endIndexes = new uint16[](2);
endIndexes[0] = 36;
endIndexes[1] = 36;
bytes[][] memory checkedCalldatas = new bytes[][](2);
bytes[] memory checkedCalldata1 = new bytes[](1);
checkedCalldata1[0] = abi.encodePacked(address(this));
checkedCalldatas[0] = checkedCalldata1;
bytes[] memory checkedCalldata2 = new bytes[](1);
checkedCalldata2[0] = abi.encodePacked(address(timelock));
checkedCalldatas[1] = checkedCalldata2;
vm.prank(address(timelock));
timelock.addCalldataChecks(
targetAddresses,
selectors,
startIndexes,
endIndexes,
checkedCalldatas
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
).length,
1,
"calldata checks not added"
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
)[0].dataHashes.length,
2,
"calldata checks not added"
);
vm.prank(address(timelock));
timelock.removeCalldataCheckDatahash(
address(lending),
MockLending.deposit.selector,
0,
keccak256(checkedCalldata1[0])
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
).length,
1,
"calldata checks not added"
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
)[0].dataHashes.length,
1,
"calldata checks not added"
);
vm.prank(address(timelock));
timelock.removeCalldataCheckDatahash(
address(lending),
MockLending.deposit.selector,
0,
keccak256(checkedCalldata2[0])
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
).length,
0,
"calldata check not removed"
);
}
function testAddCalldataCheckAndRemoveCalldataCheckDatahashMultipleIndecesSucceeds(
) public {
address[] memory targetAddresses = new address[](2);
targetAddresses[0] = address(lending);
targetAddresses[1] = address(lending);
bytes4[] memory selectors = new bytes4[](2);
selectors[0] = MockLending.deposit.selector;
selectors[1] = MockLending.deposit.selector;
/// compare first 20 bytes
uint16[] memory startIndexes = new uint16[](2);
startIndexes[0] = 16;
startIndexes[1] = 37;
uint16[] memory endIndexes = new uint16[](2);
endIndexes[0] = 36;
endIndexes[1] = 57;
bytes[][] memory checkedCalldatas = new bytes[][](2);
bytes[] memory checkedCalldata1 = new bytes[](1);
checkedCalldata1[0] = abi.encodePacked(address(this));
checkedCalldatas[0] = checkedCalldata1;
bytes[] memory checkedCalldata2 = new bytes[](1);
checkedCalldata2[0] = abi.encodePacked(address(timelock));
checkedCalldatas[1] = checkedCalldata2;
vm.prank(address(timelock));
timelock.addCalldataChecks(
targetAddresses,
selectors,
startIndexes,
endIndexes,
checkedCalldatas
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
).length,
2,
"calldata checks not added"
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
)[0].dataHashes.length,
1,
"first calldata checks not added"
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
)[1].dataHashes.length,
1,
"second calldata checks not added"
);
vm.prank(address(timelock));
timelock.removeCalldataCheckDatahash(
address(lending),
MockLending.deposit.selector,
0,
keccak256(checkedCalldata1[0])
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
).length,
1,
"calldata checks not added"
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
)[0].dataHashes.length,
1,
"calldata checks not added"
);
vm.prank(address(timelock));
timelock.removeCalldataCheckDatahash(
address(lending),
MockLending.deposit.selector,
0,
keccak256(checkedCalldata2[0])
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
).length,
0,
"calldata check not removed"
);
}
function testAddCalldataCheckFailsWhenOverlap() public {
address[] memory targetAddresses = new address[](2);
targetAddresses[0] = address(lending);
targetAddresses[1] = address(lending);
bytes4[] memory selectors = new bytes4[](2);
selectors[0] = MockLending.deposit.selector;
selectors[1] = MockLending.deposit.selector;
/// compare first 20 bytes
uint16[] memory startIndexes = new uint16[](2);
startIndexes[0] = 16;
startIndexes[1] = 20;
uint16[] memory endIndexes = new uint16[](2);
endIndexes[0] = 36;
endIndexes[1] = 40;
bytes[][] memory checkedCalldatas = new bytes[][](2);
bytes[] memory checkedCalldata1 = new bytes[](1);
checkedCalldata1[0] = abi.encodePacked(address(this));
checkedCalldatas[0] = checkedCalldata1;
bytes[] memory checkedCalldata2 = new bytes[](1);
checkedCalldata2[0] = abi.encodePacked(address(timelock));
checkedCalldatas[1] = checkedCalldata2;
vm.expectRevert("CalldataList: Partial check overlap");
vm.prank(address(timelock));
timelock.addCalldataChecks(
targetAddresses,
selectors,
startIndexes,
endIndexes,
checkedCalldatas
);
}
function testAddCalldataCheckFailsWithDuplicateData() public {
address[] memory targetAddresses = new address[](2);
targetAddresses[0] = address(lending);
targetAddresses[1] = address(lending);
bytes4[] memory selectors = new bytes4[](2);
selectors[0] = MockLending.deposit.selector;
selectors[1] = MockLending.deposit.selector;
/// compare first 20 bytes
uint16[] memory startIndexes = new uint16[](2);
startIndexes[0] = 16;
startIndexes[1] = 16;
uint16[] memory endIndexes = new uint16[](2);
endIndexes[0] = 36;
endIndexes[1] = 36;
bytes[][] memory checkedCalldatas = new bytes[][](2);
bytes[] memory checkedCalldata1 = new bytes[](1);
checkedCalldata1[0] = abi.encodePacked(address(this));
checkedCalldatas[0] = checkedCalldata1;
bytes[] memory checkedCalldata2 = new bytes[](1);
checkedCalldata2[0] = abi.encodePacked(address(this));
checkedCalldatas[1] = checkedCalldata2;
vm.expectRevert("CalldataList: Duplicate data");
vm.prank(address(timelock));
timelock.addCalldataChecks(
targetAddresses,
selectors,
startIndexes,
endIndexes,
checkedCalldatas
);
}
function testAddCalldataCheckFailsWhenTargetZeroAddress() public {
address[] memory targetAddresses = new address[](2);
targetAddresses[0] = address(0);
targetAddresses[1] = address(lending);
bytes4[] memory selectors = new bytes4[](2);
selectors[0] = MockLending.deposit.selector;
selectors[1] = MockLending.deposit.selector;
/// compare first 20 bytes
uint16[] memory startIndexes = new uint16[](2);
startIndexes[0] = 16;
startIndexes[1] = 16;
uint16[] memory endIndexes = new uint16[](2);
endIndexes[0] = 36;
endIndexes[1] = 36;
bytes[][] memory checkedCalldatas = new bytes[][](2);
bytes[] memory checkedCalldata1 = new bytes[](1);
checkedCalldata1[0] = abi.encodePacked(address(this));
checkedCalldatas[0] = checkedCalldata1;
bytes[] memory checkedCalldata2 = new bytes[](1);
checkedCalldata2[0] = abi.encodePacked(address(timelock));
checkedCalldatas[1] = checkedCalldata2;
vm.expectRevert("CalldataList: Address cannot be zero");
vm.prank(address(timelock));
timelock.addCalldataChecks(
targetAddresses,
selectors,
startIndexes,
endIndexes,
checkedCalldatas
);
}
function testAddCalldataCheckFailsWhenTargetSelectorZero() public {
address[] memory targetAddresses = new address[](2);
targetAddresses[0] = address(lending);
targetAddresses[1] = address(lending);
bytes4[] memory selectors = new bytes4[](2);
selectors[0] = "";
selectors[1] = MockLending.deposit.selector;
/// compare first 20 bytes
uint16[] memory startIndexes = new uint16[](2);
startIndexes[0] = 16;
startIndexes[1] = 16;
uint16[] memory endIndexes = new uint16[](2);
endIndexes[0] = 36;
endIndexes[1] = 36;
bytes[][] memory checkedCalldatas = new bytes[][](2);
bytes[] memory checkedCalldata1 = new bytes[](1);
checkedCalldata1[0] = abi.encodePacked(address(this));
checkedCalldatas[0] = checkedCalldata1;
bytes[] memory checkedCalldata2 = new bytes[](1);
checkedCalldata2[0] = abi.encodePacked(address(timelock));
checkedCalldatas[1] = checkedCalldata2;
vm.expectRevert("CalldataList: Selector cannot be empty");
vm.prank(address(timelock));
timelock.addCalldataChecks(
targetAddresses,
selectors,
startIndexes,
endIndexes,
checkedCalldatas
);
}
function testRemoveCalldataCheckDatahashFailsForOutOfBoundIndex() public {
address[] memory targetAddresses = new address[](2);
targetAddresses[0] = address(lending);
targetAddresses[1] = address(lending);
bytes4[] memory selectors = new bytes4[](2);
selectors[0] = MockLending.deposit.selector;
selectors[1] = MockLending.deposit.selector;
/// compare first 20 bytes
uint16[] memory startIndexes = new uint16[](2);
startIndexes[0] = 16;
startIndexes[1] = 16;
uint16[] memory endIndexes = new uint16[](2);
endIndexes[0] = 36;
endIndexes[1] = 36;
bytes[][] memory checkedCalldatas = new bytes[][](2);
bytes[] memory checkedCalldata1 = new bytes[](1);
checkedCalldata1[0] = abi.encodePacked(address(this));
checkedCalldatas[0] = checkedCalldata1;
bytes[] memory checkedCalldata2 = new bytes[](1);
checkedCalldata2[0] = abi.encodePacked(address(timelock));
checkedCalldatas[1] = checkedCalldata2;
vm.prank(address(timelock));
timelock.addCalldataChecks(
targetAddresses,
selectors,
startIndexes,
endIndexes,
checkedCalldatas
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
).length,
1,
"calldata checks not added"
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
)[0].dataHashes.length,
2,
"calldata checks not added"
);
vm.expectRevert("CalldataList: Calldata index out of bounds");
vm.prank(address(timelock));
timelock.removeCalldataCheckDatahash(
address(lending),
MockLending.deposit.selector,
1,
keccak256(checkedCalldata1[0])
);
}
function testRemoveCalldataCheckDatahashFailsWhenDataHashNotExist()
public
{
address[] memory targetAddresses = new address[](2);
targetAddresses[0] = address(lending);
targetAddresses[1] = address(lending);
bytes4[] memory selectors = new bytes4[](2);
selectors[0] = MockLending.deposit.selector;
selectors[1] = MockLending.deposit.selector;
/// compare first 20 bytes
uint16[] memory startIndexes = new uint16[](2);
startIndexes[0] = 16;
startIndexes[1] = 16;
uint16[] memory endIndexes = new uint16[](2);
endIndexes[0] = 36;
endIndexes[1] = 36;
bytes[][] memory checkedCalldatas = new bytes[][](2);
bytes[] memory checkedCalldata1 = new bytes[](1);
checkedCalldata1[0] = abi.encodePacked(address(this));
checkedCalldatas[0] = checkedCalldata1;
bytes[] memory checkedCalldata2 = new bytes[](1);
checkedCalldata2[0] = abi.encodePacked(address(timelock));
checkedCalldatas[1] = checkedCalldata2;
vm.prank(address(timelock));
timelock.addCalldataChecks(
targetAddresses,
selectors,
startIndexes,
endIndexes,
checkedCalldatas
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
).length,
1,
"calldata checks not added"
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
)[0].dataHashes.length,
2,
"calldata checks not added"
);
vm.expectRevert("CalldataList: DataHash does not exist");
vm.prank(address(timelock));
timelock.removeCalldataCheckDatahash(
address(lending),
MockLending.deposit.selector,
0,
keccak256(bytes("incorrect data hash"))
);
}
/// @notice fuzz test adding multiple AND and OR checks for each contract and function selector pair
/// and removing all the checks for each pair by using removeCalldataCheck or removeCalldataCheckDatahash chosen randomly
/// @param fuzzyCheckData fuzzed CheckDataFuzzParams struct array
function testAddAndRemoveCalldataFuzzy(
CheckDataFuzzParams[] memory fuzzyCheckData
) public {
/// length of fuzzed contract-selector pair
uint256 fuzzyLength;
/// adddition of checks
{
fuzzyLength = fuzzyCheckData.length;
/// assume that fuzzyCheckData is not zero length
vm.assume(fuzzyLength > 0);
/// bound calldata length for each pair between 4 and 32, max is 32 so that
/// multiple calldatas can be generate from the seed calldata using generateCalldatas
/// min is 4 so that there are is no collision in generated calldatas
for (uint256 len = 0; len < fuzzyLength; len++) {
fuzzyCheckData[len].calldataLength =
uint16(bound(fuzzyCheckData[len].calldataLength, 4, 32));
}
/// number of AND and OR checks for each selected pair
uint256 checkCount = randomInRange(4, 20, true);
/// total length of all the AND and OR checks
uint256 length = checkCount * fuzzyLength;
/// initial start index for first check
uint16 currentStartIndex = 4;
CheckData memory checkData = _initializeCheckData(length);
/// generate checkCount number of checks for each selected pair
for (uint256 i = 0; i < fuzzyLength; i++) {
/// target should not be safe or timelock address or zero address
/// selector should not be empty
vm.assume(
fuzzyCheckData[i].target != address(safe)
&& fuzzyCheckData[i].target != address(timelock)
&& fuzzyCheckData[i].target != address(0)
&& fuzzyCheckData[i].selector != bytes4(0)
);
/// generate checkCount number of checks for the selected pair
for (uint256 j = 0; j < checkCount; j++) {
/// index where the new check is added
uint256 index = i * checkCount + j;
/// for all the checkCount number of checks target contract is same
checkData.targets[index] = fuzzyCheckData[i].target;
/// for all the checkCount number of checks target selector is same
checkData.selectors[index] = fuzzyCheckData[i].selector;
/// generate multiple OR data hashes corresponding to the current index
checkData.calldatas = generateCalldatas(
checkData.calldatas,
abi.encodePacked(fuzzyCheckData[i].seedCalldata, j),
fuzzyCheckData[i].calldataLength,
index
);
/// set start index
checkData.startIndexes[index] = currentStartIndex;
// set end index to start index + calldata length
checkData.endIndexes[index] = checkData.startIndexes[index]
+ fuzzyCheckData[i].calldataLength;
/// keep start and end index same for the next check if j <= checkCount / 2
/// update start and end index if j > checkCount / 2
if (j > checkCount / 2) {
/// update start index for next check to avoid overlap
currentStartIndex = checkData.endIndexes[index] + 1;
/// AND checks count only increases if j > checkCount / 2
totalChecks[fuzzyCheckData[i].target][fuzzyCheckData[i]
.selector] += 1;
}
}
}
vm.prank(address(timelock));
timelock.addCalldataChecks(
checkData.targets,
checkData.selectors,
checkData.startIndexes,
checkData.endIndexes,
checkData.calldatas
);
// assert calldata checks were added
for (uint256 i = 0; i < fuzzyLength; i++) {
uint256 finalCheckLength = timelock.getCalldataChecks(
fuzzyCheckData[i].target, fuzzyCheckData[i].selector
).length;
/// assert added checks count is correct
assertTrue(
finalCheckLength
== totalChecks[fuzzyCheckData[i].target][fuzzyCheckData[i]
.selector]
);
}
}
/// removal of checks
{
for (uint256 i = 0; i < fuzzyLength; i++) {
/// get number of AND checks for the selected pair
uint256 checksLength = timelock.getCalldataChecks(
fuzzyCheckData[i].target, fuzzyCheckData[i].selector
).length;
uint256 index;
/// delete all the AND checks in random order
while (checksLength > 0) {
index = randomInRange(0, checksLength - 1, false);
/// 50% chance that removeCalldataCheck will be used to remove the complete AND check
/// other 50% chance that removeCalldataCheckDatahash will be used to remove all the
/// OR checks for the AND check, finally removing the end check
if (randomInRange(1, 100, true) % 2 == 0) {
vm.prank(address(timelock));
timelock.removeCalldataCheck(
fuzzyCheckData[i].target,
fuzzyCheckData[i].selector,
index
);
} else {
/// set number of OR checks for the AND check
uint256 dataHashesLength = timelock.getCalldataChecks(
fuzzyCheckData[i].target, fuzzyCheckData[i].selector
)[index].dataHashes.length;
uint256 indexDataHashes;
/// delete all the OR checks in random order
while (dataHashesLength > 0) {
/// current array of OR data hashes
bytes32[] memory dataHashes = timelock
.getCalldataChecks(
fuzzyCheckData[i].target,
fuzzyCheckData[i].selector
)[index].dataHashes;
/// random index that will be removed
indexDataHashes =
randomInRange(0, dataHashesLength - 1, false);
vm.prank(address(timelock));
timelock.removeCalldataCheckDatahash(
fuzzyCheckData[i].target,
fuzzyCheckData[i].selector,
index,
dataHashes[indexDataHashes]
);
dataHashesLength--;
}
}
checksLength--;
}
/// assert calldata checks removed for the selected pair
assertEq(
timelock.getCalldataChecks(
fuzzyCheckData[i].target, fuzzyCheckData[i].selector
).length,
0,
"all checks not removed"
);
}
}
}
function testArityMismatchAddCalldataChecks() public {
address[] memory targets = new address[](1);
targets[0] = address(timelock);
uint256[] memory values = new uint256[](1);
values[0] = 0;
address[] memory targetAddresses = new address[](2);
targetAddresses[0] = address(lending);
targetAddresses[1] = address(lending);
bytes4[] memory selectors = new bytes4[](2);
selectors[0] = MockLending.deposit.selector;
selectors[1] = MockLending.withdraw.selector;
/// compare first 20 bytes
uint16[] memory startIndexes = new uint16[](2);
startIndexes[0] = 16;
startIndexes[1] = 16;
uint16[] memory endIndexes = new uint16[](2);
endIndexes[0] = 36;
endIndexes[1] = 36;
bytes[][] memory checkedCalldatas = new bytes[][](0);
vm.expectRevert("CalldataList: Array lengths must be equal");
vm.prank(address(timelock));
timelock.addCalldataChecks(
targetAddresses,
selectors,
startIndexes,
endIndexes,
checkedCalldatas
);
checkedCalldatas = new bytes[][](3);
checkedCalldatas[0] = new bytes[](1);
checkedCalldatas[1] = new bytes[](1);
vm.expectRevert("CalldataList: Array lengths must be equal");
vm.prank(address(timelock));
timelock.addCalldataChecks(
targetAddresses,
selectors,
startIndexes,
endIndexes,
checkedCalldatas
);
checkedCalldatas = new bytes[][](2);
bytes[] memory checkedCalldata2 = new bytes[](2);
checkedCalldata2[0] = abi.encodePacked(address(timelock));
checkedCalldata2[1] = abi.encodePacked(address(lending));
checkedCalldatas[0] = checkedCalldata2;
checkedCalldatas[1] = checkedCalldata2;
vm.prank(address(timelock));
timelock.addCalldataChecks(
targetAddresses,
selectors,
startIndexes,
endIndexes,
checkedCalldatas
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.deposit.selector
).length,
1,
"calldata check for deposit not added"
);
assertEq(
timelock.getCalldataChecks(
address(lending), MockLending.withdraw.selector
).length,
1,
"calldata check for withdraw not added"
);
}
function testAddCalldataCheckFailsStartIndexLt4() public {
bytes[] memory datas = new bytes[](1);
datas[0] = abi.encodePacked(timelock);
vm.prank(address(timelock));
vm.expectRevert("CalldataList: Start index must be greater than 3");
timelock.addCalldataCheck(
address(lending), MockLending.deposit.selector, 3, 4, datas
);
}
function testAddCalldataCheckFailsStartIndexEqEndIndexAlreadyExistingCheck()
public
{
bytes[] memory datas = new bytes[](1);
datas[0] = hex"12";
vm.prank(address(timelock));
timelock.addCalldataCheck(
address(lending), MockLending.deposit.selector, 4, 5, datas
);
datas[0] = abi.encodePacked(timelock);
vm.prank(address(timelock));
vm.expectRevert("CalldataList: Add wildcard only if no existing check");
timelock.addCalldataCheck(
address(lending), MockLending.deposit.selector, 4, 4, datas
);
}
function testAddCalldataCheckFailsStartIndexGtEndIndex() public {
bytes[] memory datas = new bytes[](1);
datas[0] = abi.encodePacked(timelock);
vm.prank(address(timelock));
vm.expectRevert(
"CalldataList: End index must be greater than start index"
);
timelock.addCalldataCheck(
address(lending), MockLending.deposit.selector, 4, 3, datas
);
}
function testAddCalldataCheckFailsWhitelistedCalldataTimelock() public {
bytes[] memory datas = new bytes[](1);
datas[0] = abi.encodePacked(timelock);
vm.prank(address(timelock));
vm.expectRevert("CalldataList: Address cannot be this");
timelock.addCalldataCheck(
address(timelock), Timelock.schedule.selector, 4, 5, datas
);
}
function testAddCalldataCheckFailsWhitelistedCalldataSafe() public {
bytes[] memory datas = new bytes[](1);
datas[0] = abi.encodePacked(timelock);
vm.prank(address(timelock));
vm.expectRevert("CalldataList: Address cannot be safe");
timelock.addCalldataCheck(
address(safe), Timelock.schedule.selector, 4, 5, datas
);
}
function testAddCalldataCheckFailsStartIndexEqEndIndexNotEq4() public {
bytes[] memory datas = new bytes[](1);
datas[0] = abi.encodePacked(timelock);
vm.prank(address(timelock));
vm.expectRevert(
"CalldataList: End index equals start index only when 4"
);
timelock.addCalldataCheck(
address(lending), MockLending.deposit.selector, 5, 5, datas
);
}