Flashloan util #35
Merged
Flashloan util #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to format files when on save
… withdraw by the owner
as the mapping is already public
also finish testing account implementation
alfulinku
commented
Jan 12, 2024
alfulinku
commented
Jan 12, 2024
if creditMultiplier != 1, rounding down can happen
eswak
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the smart account implementation that will allow users to take flashloans (from Balancer) and so be able to create leveraged positions
An integration test, working on sepolia, is here
Executing the following scenario:
should test the following scenario with a balancer flashloan and the new multicall account feature:
REQUIREMENTS: have enough token in the balancer vault (for the flashloan) and a large enough liquidity in univ2 for the swap without too much slippage. The requirements are currently met on sepolia with the current ECG deployment
Gateway implementation also fixes code-423n4/2023-12-ethereumcreditguild-findings#1041