-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
17 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
### Don't Initialize Variables with Default Value | ||
|
||
``` | ||
contracts/BlurExchange.sol::475 => uint256 totalFee = 0; | ||
``` | ||
### Use != 0 instead of > 0 for Unsigned Integer Comparison | ||
|
||
``` | ||
contracts/BlurExchange.sol::557 => return size > 0; | ||
``` | ||
### Long Revert Strings | ||
|
||
``` | ||
contracts/ExecutionDelegate.sol::22 => require(contracts[msg.sender], "Contract is not approved to make transfers"); | ||
contracts/ExecutionDelegate.sol::22 => require(contracts[msg.sender], "Contract is not approved to make transfers"); | ||
contracts/BlurExchange.sol::482 => require(totalFee <= price, "Total amount of fees are more than the price"); | ||
``` |