Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing the unnecessary function #96

Open
code423n4 opened this issue Nov 18, 2021 · 0 comments
Open

Removing the unnecessary function #96

code423n4 opened this issue Nov 18, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

xxxxx

Vulnerability details

Impact

The unnecessary code can be removed to reduce contract size.

Proof of Concept

In the contract "Alchemist.sol" the function "_expectCaller" is never used.

Tools Used

Remix solidity 0.6.12

Recommended Mitigation Steps

The function "_expectCaller(address _expectedCaller)" can be removed.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 18, 2021
code423n4 added a commit that referenced this issue Nov 18, 2021
@code423n4
xxxxx issue #96
23fee38
@Xuefeng-Zhu Xuefeng-Zhu added the duplicate This issue or pull request already exists label Dec 1, 2021
This was referenced Dec 9, 2021
Closed
Closed
Closed
@Xuefeng-Zhu Xuefeng-Zhu added sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") and removed duplicate This issue or pull request already exists labels Dec 9, 2021
@0xleastwood 0xleastwood reopened this Dec 21, 2021
@Xuefeng-Zhu Xuefeng-Zhu added the resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) label Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Xuefeng-Zhu @0xleastwood @code423n4