Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open TODOs #87

Open
code423n4 opened this issue Nov 18, 2021 · 1 comment
Open

Open TODOs #87

code423n4 opened this issue Nov 18, 2021 · 1 comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working invalid This doesn't seem right

Comments

@code423n4
Copy link
Contributor

Handle

pants

Vulnerability details

Vulnerability details

These files has open TODOs:

  • Controller.sol line 412
  • Controller.sol line 465
  • LegacyController.sol line 167

Impact

Open TODOs can hint at programming or architectural errors that still need to be fixed.

Tool Used

Manual code review.

Recommended Mitigation Steps

Resolve these TODOs and bubble up the errors.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 18, 2021
code423n4 added a commit that referenced this issue Nov 18, 2021
@code423n4
pants issue #87
187f389
@Xuefeng-Zhu Xuefeng-Zhu added the invalid This doesn't seem right label Dec 1, 2021
@0xleastwood
Copy link
Collaborator

Marking as non-critical as there is no present issue.

@0xleastwood 0xleastwood added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed invalid This doesn't seem right 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Dec 21, 2021
@Xuefeng-Zhu Xuefeng-Zhu added the invalid This doesn't seem right label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Xuefeng-Zhu @0xleastwood @code423n4