Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict _expectCaller() Mutability #8

Closed
code423n4 opened this issue Nov 17, 2021 · 2 comments
Closed

Restrict _expectCaller() Mutability #8

code423n4 opened this issue Nov 17, 2021 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

TimmyToes

Vulnerability details

Impact

_expectCaller() can be restricted to view to enable possible gas optimisations.

Proof of Concept

https://github.com/code-423n4/2021-11-yaxis/blob/0311dd421fb78f4f174aca034e8239d1e80075fe/contracts/v3/alchemix/Alchemist.sol#L757
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 17, 2021
code423n4 added a commit that referenced this issue Nov 17, 2021
@code423n4
TimmyToes issue #8
c377d75
@Xuefeng-Zhu Xuefeng-Zhu added the invalid This doesn't seem right label Nov 23, 2021
@Xuefeng-Zhu
Copy link
Collaborator

_expectCaller is not used and removed

@Xuefeng-Zhu Xuefeng-Zhu added duplicate This issue or pull request already exists and removed invalid This doesn't seem right labels Dec 9, 2021
@Xuefeng-Zhu
Copy link
Collaborator

#96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xuefeng-Zhu @code423n4