Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRANSMUTATION_PERIOD Issues #116

Open
code423n4 opened this issue Nov 18, 2021 · 0 comments
Open

TRANSMUTATION_PERIOD Issues #116

code423n4 opened this issue Nov 18, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

ye0lde

Vulnerability details

Impact

Using existing local variables instead of reading state variables will save gas by converting SLOADs to MLOADs.

Proof of Concept

newTransmutationPeriod can be used here instead of TRANSMUTATION_PERIOD :
https://github.com/code-423n4/2021-11-yaxis/blob/146febcb61ae7fe20b0920849c4f4bbe111c6ba7/contracts/v3/alchemix/Transmuter.sol#L194

TRANSMUTATION_PERIOD is named like a constant when it is actually an updatable state variable.

Tools Used

Visual Studio Code, Remix

Recommended Mitigation Steps

Use the local variable instead of the state variable.
Rename TRANSMUTATION_PERIOD appropriately.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 18, 2021
code423n4 added a commit that referenced this issue Nov 18, 2021
@code423n4
ye0lde issue #116
a0078f3
@Xuefeng-Zhu Xuefeng-Zhu added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 23, 2021
@Xuefeng-Zhu Xuefeng-Zhu added the resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) label Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xuefeng-Zhu @code423n4