Skip to content

Issues: code-423n4/2021-11-yaxis-findings

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

67 Open 55 Closed
67 Open 55 Closed
Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

several functions can be marked external bug Something isn't working fix later G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#119 opened Nov 19, 2021 by code423n4
Incorrect comment or code in runPhasedDistribution (Transmuter.sol) 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue wont fix
#117 opened Nov 18, 2021 by code423n4
1
TRANSMUTATION_PERIOD Issues bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#116 opened Nov 18, 2021 by code423n4
Unused Named Returns bug Something isn't working G (Gas Optimization) sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue wont fix
#115 opened Nov 18, 2021 by code423n4
2
Assigned operations to constant variables bug Something isn't working G (Gas Optimization) sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue wont fix
#111 opened Nov 18, 2021 by code423n4
3
Constant expressions bug Something isn't working G (Gas Optimization) sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue wont fix
#110 opened Nov 18, 2021 by code423n4
1
setSentinel actually adds sentinel 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
#108 opened Nov 18, 2021 by code423n4
3
_setupRole not in constructor 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working invalid This doesn't seem right sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
#107 opened Nov 18, 2021 by code423n4
2
Context and msg.sender 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#105 opened Nov 18, 2021 by code423n4
anyone can deposit to adapters directly 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons wont fix
#103 opened Nov 18, 2021 by code423n4
Optimize Alchemist.sol#_withdrawFundsTo bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#102 opened Nov 18, 2021 by code423n4
AlchemistVault.sol can be optimised bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#100 opened Nov 18, 2021 by code423n4
Gas optimization: Reduce storage write bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#97 opened Nov 18, 2021 by code423n4
Removing the unnecessary function bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#96 opened Nov 18, 2021 by code423n4
CDP.sol#getUpdatedTotalDebt can be optimized bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#92 opened Nov 18, 2021 by code423n4
CDP.sol#update.sol can be optimized bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#91 opened Nov 18, 2021 by code423n4
Require statements without messages 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working wont fix
#88 opened Nov 18, 2021 by code423n4
2
Open TODOs 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working invalid This doesn't seem right
#87 opened Nov 18, 2021 by code423n4
1
State variables can be immutables bug Something isn't working G (Gas Optimization) invalid This doesn't seem right
#83 opened Nov 18, 2021 by code423n4
1
Incorrect Comment 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
#77 opened Nov 18, 2021 by code423n4
2
No Event Emitted on Minting 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue wont fix
#76 opened Nov 18, 2021 by code423n4
3
Lack of Input Validation 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue wont fix
#75 opened Nov 18, 2021 by code423n4
2
Gas Optimization: Inline instead of modifier bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#72 opened Nov 18, 2021 by code423n4
No incentive to call transmute() instead of forceTransmute(self) 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons wont fix
#68 opened Nov 18, 2021 by code423n4
1
Transmuter.unstake updates user without first updating distributing yield 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#66 opened Nov 18, 2021 by code423n4
ProTip! Type g i on any issue or pull request to go back to the issue listing page.