Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlocked pragma is used in most contracts #51

Closed
code423n4 opened this issue Nov 27, 2021 · 2 comments
Closed

Unlocked pragma is used in most contracts #51

code423n4 opened this issue Nov 27, 2021 · 2 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

hyh

Vulnerability details

Impact

As different compiler versions have critical behavior specifics if the contracts get accidentally deployed using another compiler version compared to one they tested with, various types of undesired behavior can be introduced

Proof of Concept

Most of the contracts use pragma solidity >=0.6.6.
Basically all of them, just a few links:
https://github.com/code-423n4/2021-11-malt/blob/main/src/contracts/MiningService.sol#L1
https://github.com/code-423n4/2021-11-malt/blob/main/src/contracts/DAO.sol#L1
https://github.com/code-423n4/2021-11-malt/blob/main/src/contracts/PoolTransferVerification.sol#L1
...

Recommended Mitigation Steps

Fix the compiler version across the system
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 27, 2021
code423n4 added a commit that referenced this issue Nov 27, 2021
@code423n4
hyh issue #51
73fc166
@0xScotch 0xScotch added the duplicate This issue or pull request already exists label Dec 8, 2021
@0xScotch
Copy link
Collaborator

0xScotch commented Dec 8, 2021

#185

@0xScotch 0xScotch closed this as completed Dec 8, 2021
@GalloDaSballo
Copy link
Collaborator

Duplicate of #185

@GalloDaSballo GalloDaSballo marked this as a duplicate of #185 Jan 24, 2022
@CloudEllie CloudEllie added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@GalloDaSballo @0xScotch @code423n4 @CloudEllie