Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ring instead of rsa for ADB direct authentication #67

Open
cocool97 opened this issue Nov 30, 2024 · 1 comment
Open

Use ring instead of rsa for ADB direct authentication #67

cocool97 opened this issue Nov 30, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@cocool97
Copy link
Owner

Ring library is already used as a dependency of rustls, and does not have known vulnerabilities.

@cocool97 cocool97 added the enhancement New feature or request label Dec 1, 2024
@pavi2410
Copy link

aws-lc-sys crate, which has a dependency on the rsa crate used by adb_client crate, fails to compile on Windows 11 due to missing cmake external dependency.

error: failed to run custom build command for `aws-lc-sys v0.23.1`

Caused by:
  process didn't exit successfully: `D:\Projects\Kodular\Starter\src-tauri\target\debug\build\aws-lc-sys-52ee19cb97b7a6c1\build-script-main` (exit code: 101)
  --- stdout
  cargo:rerun-if-env-changed=AWS_LC_SYS_NO_PREFIX
  cargo:rerun-if-env-changed=AWS_LC_SYS_PREGENERATING_BINDINGS
  cargo:rerun-if-env-changed=AWS_LC_SYS_EXTERNAL_BINDGEN
  cargo:rerun-if-env-changed=AWS_LC_SYS_NO_ASM
  cargo:rerun-if-env-changed=AWS_LC_SYS_CFLAGS
  cargo:rerun-if-env-changed=AWS_LC_SYS_PREBUILT_NASM
  cargo:rerun-if-env-changed=AWS_LC_SYS_C_STD
  cargo:rustc-cfg=x86_64_pc_windows_msvc
  cargo:rerun-if-env-changed=AWS_LC_SYS_CMAKE_BUILDER
  cargo:rerun-if-env-changed=AWS_LC_SYS_STATIC
  default_for Target: 'x86_64-pc-windows-msvc'
  cargo:rerun-if-env-changed=AWS_LC_SYS_STATIC
  cargo:rerun-if-env-changed=CMAKE

  --- stderr
  Missing dependency: cmake
  thread 'main' panicked at C:\Users\Pavitra\.cargo\registry\src\index.crates.io-6f17d22bba15001f\aws-lc-sys-0.23.1\builder/main.rs:372:40:
  called `Result::unwrap()` on an `Err` value: "Required build dependency is missing. Halting build."
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants