Changes assignments filter to return a number to be more boolean safe…

… over an http endpoint
coconutcalendar · Nov 28, 2019 · 459f602 · 459f602
1 parent d75b667
commit 459f602
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/resources/location.test.ts b/src/resources/location.test.ts
@@ -191,7 +191,7 @@ it('can get locations with additional parameters', async () => {
   expect(mockAxios.get).toHaveBeenCalledTimes(1);
   expect(mockAxios.get).toHaveBeenCalledWith('locations', {
     params: {
-      'filter[assignments]': true,
+      'filter[assignments]': 1,
       'filter[city]': 'Fake City',
       'filter[country]': 'FC',
       'filter[invite_only]': 1,

diff --git a/src/resources/location.ts b/src/resources/location.ts
@@ -25,7 +25,7 @@ export interface LocationFilter {
 }
 
 export interface LocationParameters {
-  assignments?: boolean;
+  assignments?: number;
   city?: string;
   country?: string;
   invite_only?: number;
@@ -192,7 +192,7 @@ export default class Location extends Conditional implements LocationResource {
     const params: LocationParameters = {};
 
     if (typeof this.filters.assigned !== 'undefined') {
-      params.assignments = this.filters.assigned;
+      params.assignments = Number(this.filters.assigned);
     }
 
     if (typeof this.filters.city !== 'undefined') {

diff --git a/src/resources/service.test.ts b/src/resources/service.test.ts
@@ -164,7 +164,7 @@ it('can get services with additional parameters', async () => {
   expect(mockAxios.get).toHaveBeenCalledTimes(1);
   expect(mockAxios.get).toHaveBeenCalledWith('services', {
     params: {
-      'filter[assignments]': true,
+      'filter[assignments]': 1,
       'filter[category]': 3,
       'filter[group]': 0,
       'filter[invite_only]': 1,

diff --git a/src/resources/service.ts b/src/resources/service.ts
@@ -14,7 +14,7 @@ export interface ServiceFilter {
 }
 
 export interface ServiceParameters {
-  assignments?: boolean;
+  assignments?: number;
   category?: number | string;
   group?: number;
   invite_only?: number;
@@ -142,7 +142,7 @@ export default class Service extends Conditional implements ServiceResource {
     const params: ServiceParameters = {};
 
     if (typeof this.filters.assigned !== 'undefined') {
-      params.assignments = this.filters.assigned;
+      params.assignments = Number(this.filters.assigned);
     }
 
     if (typeof this.filters.category !== 'undefined') {