Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile all exposed classes #28

Closed
matshou opened this issue Jan 31, 2021 · 0 comments
Closed

Compile all exposed classes #28

matshou opened this issue Jan 31, 2021 · 0 comments
Labels
breaking Breaking changes enhancement New feature or request
Milestone

Comments

@matshou
Copy link
Member

matshou commented Jan 31, 2021

In the current version the application is extrapolating which classes are exposed by reading methods declared in LuaManager#GlobalObject or more precisely their parameters and return values.

While it is true that class references used in exposed global methods are going to be exposed themselves, just collecting these references does not encompass all exposed classes. The only way to do that is to obtain it programmatically from code.

All exposed classes are stored as Class<?> objects in HashSet exposed variable in a private inner class LuaManager#Exposer. We need to add Zomboid classes and libraries to application classpath and employ reflection to read these objects.

@matshou matshou added the enhancement New feature or request label Jan 31, 2021
@matshou matshou added this to the Release 2.0.0 milestone Jan 31, 2021
@matshou matshou added breaking Breaking changes enhancement New feature or request and removed enhancement New feature or request labels Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant