Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix FK validation join implementation #4361

Closed
jseldess opened this issue Feb 12, 2019 · 4 comments
Closed

sql: fix FK validation join implementation #4361

jseldess opened this issue Feb 12, 2019 · 4 comments
Assignees
Labels
C-product-change P-1 High priority; must be done this release
Milestone

Comments

@jseldess
Copy link
Contributor

PR: cockroachdb/cockroach#34365

From release notes:

VALIDATE CONSTRAINT is now compatible with the new MATCH FULL and MATCH SIMPLE foreign key semantics and is more performant. [#34365][#34365] {% comment %}doc{% endcomment %}

@jseldess jseldess added this to the 2.2 milestone Feb 12, 2019
@jseldess
Copy link
Contributor Author

@rmloveland, not sure if/how this affects docs.

@jseldess jseldess added A-sql P-1 High priority; must be done this release labels Feb 13, 2019
@rmloveland
Copy link
Contributor

@lucy-zhang ,

Based on my reading of the release note, this appears to be a bugfix/perf thing that does not affect the existing VALIDATE CONSTRAINT docs, since (1) the docs don't mention this specific case (nor its performance), and (2) AFAICT your PR changes the behavior to what a user would expect. Do you agree with that assessment?

@thoszhang
Copy link

@rmloveland yes, I agree

@rmloveland
Copy link
Contributor

Thanks! Closing...

@rmloveland rmloveland removed the ready label Feb 14, 2019
@jseldess jseldess modified the milestones: 2.2, 19.1 Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-product-change P-1 High priority; must be done this release
Projects
None yet
Development

No branches or pull requests

3 participants