Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: require yarn >= 1.7.0 #3444

Closed
jseldess opened this issue Jul 31, 2018 · 3 comments
Closed

ui: require yarn >= 1.7.0 #3444

jseldess opened this issue Jul 31, 2018 · 3 comments
Assignees
Milestone

Comments

@jseldess
Copy link
Contributor

PR: cockroachdb/cockroach#27262

From release notes:

Building CockroachDB from source now requires yarn at version 1.7.0 or above. [#27262][#27262] {% comment %}doc{% endcomment %}

@jseldess jseldess added this to the 2.1 milestone Jul 31, 2018
@Amruta-Ranade Amruta-Ranade self-assigned this Aug 2, 2018
@Amruta-Ranade
Copy link
Contributor

As discussed with @benesch, this issue doesn't require doc updates because the documented procedure to build from source doesn't require yarn. Closing this issue.

@jseldess
Copy link
Contributor Author

jseldess commented Aug 6, 2018

Thanks, @Amruta-Ranade. For this type of update, we also always want to check the cockroach CONTRIBUTING.md. That's where our most explicit build from source instructions are. But it turns out that the yarn requirement is already up-to-date there as well!

@Amruta-Ranade
Copy link
Contributor

@jseldess Oh! Didn't know that. Made a note of it for next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants