Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: CheckSSTConflicts fails to handle intents above MVCC range keys #93934

Closed
erikgrinaker opened this issue Dec 19, 2022 · 0 comments · Fixed by #93938
Closed

storage: CheckSSTConflicts fails to handle intents above MVCC range keys #93934

erikgrinaker opened this issue Dec 19, 2022 · 0 comments · Fixed by #93938
Assignees
@erikgrinaker
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-storage Storage Team

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Dec 19, 2022 •
edited by exalate-issue-sync bot
Loading

Adding AddSSTable support for kvnemesis (#89145) uncovered a bug in CheckSSTConflicts intent handling: an intent above an MVCC range tombstone would be considered a point key covered by the MVCC range tombstone due to its 0-valued timestamp, and thus not processed as an intent.

Jira issue: CRDB-22606

Epic CRDB-20465
@erikgrinaker erikgrinaker added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-storage Relating to our storage engine (Pebble) on-disk storage. T-storage Storage Team labels Dec 19, 2022
@erikgrinaker erikgrinaker self-assigned this Dec 19, 2022
@erikgrinaker erikgrinaker mentioned this issue Dec 19, 2022
Merged
@craig craig bot closed this as completed in 8cca165 Dec 20, 2022
@blathers-crl blathers-crl bot mentioned this issue Dec 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-storage Storage Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

storage: fix CheckSSTConflicts intent conflict above MVCC range tombstone erikgrinaker/cockroach
1 participant
@erikgrinaker