Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base: consider setting NetworkTimeout to 1 second #93007

Closed
erikgrinaker opened this issue Dec 4, 2022 · 2 comments
Closed

base: consider setting NetworkTimeout to 1 second #93007

erikgrinaker opened this issue Dec 4, 2022 · 2 comments
Labels
A-kv-server Relating to the KV-level RPC server C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Dec 4, 2022 •
edited
Loading

In #92542, the NetworkTimeout and other associated timeouts were reduced to 2 seconds, with a 4 second DialTimeout. However, the analysis in that PR shows that we should be fine to drop the timeout further to 1 second (with a 2 second DialTimeout), even for multiregion clusters. This wasn't done out of caution, but we should consider it after trying it out in cloud.

Jira issue: CRDB-22104
@erikgrinaker erikgrinaker added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv-server Relating to the KV-level RPC server T-kv-replication labels Dec 4, 2022
@blathers-crl
Copy link

blathers-crl bot commented Dec 4, 2022

cc @cockroachdb/replication

@erikgrinaker erikgrinaker mentioned this issue Dec 4, 2022
Merged
@erikgrinaker erikgrinaker added T-kv KV Team and removed T-kv-replication labels May 30, 2023
@erikgrinaker erikgrinaker mentioned this issue Aug 23, 2023
Open
@erikgrinaker
Copy link
Contributor Author

Let's not. We've seen even 2s can be overly aggressive in some cases, which prompted #109578. Reducing the gRPC server-side keepalive timeout doesn't really buy us anything anyway, availability-wise, what we really want is to reduce the RPC heartbeat timeout which requires #93397.

@github-project-automation github-project-automation bot moved this to Closed in KV Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-kv-server Relating to the KV-level RPC server C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
No open projects
KV
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erikgrinaker