Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: update support for npgsql #92623

Closed
dikshant opened this issue Nov 28, 2022 · 3 comments · Fixed by #97253
Closed

sql: update support for npgsql #92623

dikshant opened this issue Nov 28, 2022 · 3 comments · Fixed by #97253
Assignees
@rafiss
Labels
A-tools-npgsql C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@dikshant
Copy link

dikshant commented Nov 28, 2022 •
edited
Loading

Npgsql is on major version 6.0, we are only on 4.x. We should update our support and get Npgsql out of beta.
https://www.cockroachlabs.com/docs/stable/third-party-database-tools.html

Jira issue: CRDB-21889

Epic CRDB-17785
@dikshant dikshant added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-tools-hibernate Issues that pertain to Hibernate integration. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) A-tools-prisma A-tools-npgsql labels Nov 28, 2022
@dikshant dikshant changed the title sql: update support for third party tools sql: update support for npgsql Dec 14, 2022
@dikshant dikshant removed A-tools-hibernate Issues that pertain to Hibernate integration. A-tools-prisma labels Dec 14, 2022
@dikshant
Copy link
Author

dikshant commented Dec 28, 2022 •
edited
Loading

After removing pg_advisory_xact_lock from the create table statements used in npgsql tests and removing the three failed tests due to #94356. I was able to obtain the following test run log (attached below) by running npgsql (v7.0) against CockroachDB 22.2.1.

As it stands:

Failed!  - Failed:   904, Passed:  2381, Skipped:   272, Total:  3557, Duration: 3 m 57 s - Npgsql.Tests.dll (net7.0)

203 of these are unimplemented errors.

Some of these could be bugs in CRDB or npgsql not working well without changes:

Failed Within_transaction [15 ms]
Error Message:
Npgsql.NpgsqlException : Received backend message ReadyForQuery while expecting CommandCompleteMessage. Please file a bug.

npgsql_full_test_run.log

@rafiss
Copy link
Collaborator

rafiss commented Jan 3, 2023

Nice results. Could you share some instructions onw how you set up the npgsql environment, and the command you used to run the tests?

@dikshant
Copy link
Author

dikshant commented Jan 4, 2023

The steps are:

  1. git clone https://github.com/npgsql/npgsql.git
  2. Open the project using VSCode.
  3. Install this extension used for remote development.
  4. Click this on the bottom:
    Screenshot 2023-01-04 at 3 03 36 PM
  5. Select reopen in container:
    Screenshot 2023-01-04 at 2 53 54 PM
  6. Apply this git diff.
  7. Run: dotnet test test/Npgsql.Tests from the project root.

@dikshant dikshant mentioned this issue Jan 26, 2023
Open
@rafiss rafiss mentioned this issue Feb 16, 2023
Merged
@craig craig bot closed this as completed in 9a5ff96 Feb 16, 2023
@craig craig bot closed this as completed in #97253 Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafiss rafiss

Labels
A-tools-npgsql C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachtest: add npgsql nightly test rafiss/cockroach
2 participants
@rafiss @dikshant