Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: add 23.1 version gate to frontend SQL insights queries #92352

Closed
ericharmeling opened this issue Nov 22, 2022 · 1 comment
Closed

ui: add 23.1 version gate to frontend SQL insights queries #92352

ericharmeling opened this issue Nov 22, 2022 · 1 comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@ericharmeling
Copy link
Contributor

ericharmeling commented Nov 22, 2022 •
edited by cockroach-jira-scripts
Loading

#90660 added a contention_events column to the crdb_internal.cluster_execution_insights table, and #91668 updated the workloadInsightsQuery SQL query in pkg/ui/workspaces/cluster-ui/src/api/insightsApi.ts to select from this column.

These PRs will not be backported to release-22.2. Using a cluster-ui build with these updates against a 22.2 cluster will cause the SQL-over-HTTP API to respond with an error, and the front end to show an empty statement insights table. We should add a version gate to the front-end queries to prevent mixed-version clusters from selecting from the contention_events column in 22.2 databases.

Jira issue: CRDB-21715
@ericharmeling ericharmeling added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-observability labels Nov 22, 2022
@maryliag
Copy link
Contributor

maryliag commented Nov 3, 2023

No longer a priority

@maryliag maryliag closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maryliag @ericharmeling