Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global tables cause changefeeds to stop with an error #91922

Closed
aliher1911 opened this issue Nov 15, 2022 · 0 comments · Fixed by #91920
Closed

global tables cause changefeeds to stop with an error #91922

aliher1911 opened this issue Nov 15, 2022 · 0 comments · Fixed by #91920
Assignees
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@aliher1911
Copy link
Contributor

aliher1911 commented Nov 15, 2022

Describe the problem

When using global tables, changefeed jobs could stop with error like:

job failed (job 808401699232022529: failed to update record 1ec4a4bb-c5fe-433f-8e9f-98c605929a75: protectedts-update: could not parse "1666775632584715007.0000000000?" as type decimal)

as reported by client.

This is caused by using hlc.Timestamp.AsOfSystemTime() when inserting values in protected timestamps internal table.

row, err := p.ex.QueryRowEx(ctx, "protectedts-update", txn,
sessiondata.InternalExecutorOverride{User: security.NodeUserName()},
updateTimestampQuery, id.GetBytesMut(), timestamp.AsOfSystemTime())

Schema expects decimal value and can't accept synthetic syntax with trailing '?' which was added in 21.1.

Reported against
CockroachDB Version: v22.1.9

But all versions should be affected.

Jira issue: CRDB-21489

@aliher1911 aliher1911 added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Nov 15, 2022
@aliher1911 aliher1911 self-assigned this Nov 15, 2022
@craig craig bot closed this as completed in 03f6062 Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant